From: Alan Cox <alan-qBU/x9rampVanCEyBjwyrvXRex20P6io@public.gmane.org>
To: Corentin Chary <corentincj-EjuBZuxMvz2sTnJN9+BGXg@public.gmane.org>
Cc: Matt Fleming
<matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org>,
Matthew Garrett <mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
"platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Alessandro Crismani
<alessandro.crismani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mikhail Bakhterev
<mike.bakhterev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Patrick H <kernel-0BLq+tI11CLk1uMJSBkQmQ@public.gmane.org>,
Matt Fleming
<matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
"H. Peter Anvin" <hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org>,
stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] samsung-laptop: Disable if CONFIG_EFI=y
Date: Sun, 4 Nov 2012 19:37:41 +0000 [thread overview]
Message-ID: <20121104193741.7b4ca37b@pyramind.ukuu.org.uk> (raw)
In-Reply-To: <CAHR064isMXk8qkqhBJ==9sRRP7xC_j_K5rqXApza-LNkosp5mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
> Acked-by: Corentin Chary <corentin.chary-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
This is totally bogus and prevents users build a kernel which can work in
either mode. As such its a regression.
Do the detection check at runtime. If it was booted via EFI then don't
grovel in places you shouldn't. Indeed its possible EFI should reserve
those memory regions ?
Alan
next prev parent reply other threads:[~2012-11-04 19:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-04 17:35 [PATCH] samsung-laptop: Disable if CONFIG_EFI=y Matt Fleming
2012-11-04 17:44 ` Corentin Chary
[not found] ` <CAHR064isMXk8qkqhBJ==9sRRP7xC_j_K5rqXApza-LNkosp5mg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-04 19:37 ` Alan Cox [this message]
2012-11-05 9:12 ` Corentin Chary
2012-11-05 10:30 ` Greg KH
2012-11-05 11:50 ` Matt Fleming
2012-11-05 12:07 ` Alan Cox
2012-11-05 12:09 ` Matt Fleming
2012-11-05 12:12 ` Matt Fleming
2012-11-05 12:13 ` Matt Fleming
2012-11-04 17:47 ` Jonathan Nieder
[not found] ` <20121104174713.GA28414-fcEM2ccDkbL2nhBuCrrZHw@public.gmane.org>
2012-11-04 20:58 ` Matt Fleming
2012-11-05 10:37 ` Greg KH
2012-11-05 12:09 ` Matt Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121104193741.7b4ca37b@pyramind.ukuu.org.uk \
--to=alan-qbu/x9rampvanceybjwyrvxrex20p6io@public.gmane.org \
--cc=alessandro.crismani-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=corentincj-EjuBZuxMvz2sTnJN9+BGXg@public.gmane.org \
--cc=hpa-YMNOUZJC4hwAvxtiuMwx3w@public.gmane.org \
--cc=kernel-0BLq+tI11CLk1uMJSBkQmQ@public.gmane.org \
--cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=matt-HNK1S37rvNbeXh+fF434Mdi2O/JbrIOy@public.gmane.org \
--cc=matt.fleming-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=mike.bakhterev-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=mjg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox