From: Jean Delvare <khali@linux-fr.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: lm-sensors@lm-sensors.org,
"Mark M. Hoffman" <mhoffman@lightlink.com>,
George Joseph <george.joseph@fairview5.com>,
Juerg Haefliger <juergh@gmail.com>,
Steve Glendinning <steve.glendinning@shawell.net>,
Riku Voipio <riku.voipio@iki.fi>,
Guillaume Ligneul <guillaume.ligneul@gmail.com>,
"Hans J. Koch" <hjk@hansjkoch.de>,
Roger Lucas <vt8231@hiddenengine.co.uk>,
Marc Hulsman <m.hulsman@tudelft.nl>,
Rudolf Marek <r.marek@assembler.cz>,
Corentin Chary <corentin.chary@gmail.com>,
Matthew Garrett <mjg@redhat.com>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 2/3] platform/x86: (eeepc-laptop) Replace SENSORS_LIMIT with clamp_val
Date: Wed, 9 Jan 2013 23:01:51 +0100 [thread overview]
Message-ID: <20130109230151.7d4679af@endymion.delvare> (raw)
In-Reply-To: <1357750750-30512-2-git-send-email-linux@roeck-us.net>
On Wed, 9 Jan 2013 08:59:08 -0800, Guenter Roeck wrote:
> SENSORS_LIMIT and clamp_val have the same functionality, so retire SENSORS_LIMIT
> as it is no longer needed.
>
> The change reduces text size by 26 bytes and bss size by 16 bytes on x86_86
> builds.
>
> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/platform/x86/eeepc-laptop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/platform/x86/eeepc-laptop.c b/drivers/platform/x86/eeepc-laptop.c
> index 528e949..a5da0b5 100644
> --- a/drivers/platform/x86/eeepc-laptop.c
> +++ b/drivers/platform/x86/eeepc-laptop.c
> @@ -1007,7 +1007,7 @@ static int eeepc_get_fan_pwm(void)
>
> static void eeepc_set_fan_pwm(int value)
> {
> - value = SENSORS_LIMIT(value, 0, 255);
> + value = clamp_val(value, 0, 255);
> value = value * 100 / 255;
> ec_write(EEEPC_EC_FAN_PWM, value);
> }
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
next prev parent reply other threads:[~2013-01-09 22:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-09 16:59 [PATCH 1/3] hwmon: Replace SENSORS_LIMIT with clamp_val Guenter Roeck
2013-01-09 16:59 ` [PATCH 2/3] platform/x86: (eeepc-laptop) " Guenter Roeck
2013-01-09 22:01 ` Jean Delvare [this message]
2013-01-09 16:59 ` [PATCH 3/3] hwmon: Retire SENSORS_LIMIT Guenter Roeck
2013-01-09 22:03 ` Jean Delvare
2013-01-09 21:58 ` [PATCH 1/3] hwmon: Replace SENSORS_LIMIT with clamp_val Jean Delvare
2013-01-09 23:50 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130109230151.7d4679af@endymion.delvare \
--to=khali@linux-fr.org \
--cc=corentin.chary@gmail.com \
--cc=george.joseph@fairview5.com \
--cc=guillaume.ligneul@gmail.com \
--cc=hjk@hansjkoch.de \
--cc=juergh@gmail.com \
--cc=linux@roeck-us.net \
--cc=lm-sensors@lm-sensors.org \
--cc=m.hulsman@tudelft.nl \
--cc=mhoffman@lightlink.com \
--cc=mjg@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=r.marek@assembler.cz \
--cc=riku.voipio@iki.fi \
--cc=steve.glendinning@shawell.net \
--cc=vt8231@hiddenengine.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox