From: Matthew Garrett <mjg59@srcf.ucam.org>
To: AceLan Kao <acelan.kao@canonical.com>
Cc: platform-driver-x86@vger.kernel.org,
Colin Ian King <colin.king@canonical.com>
Subject: Re: [PATCH] dell: add new dell WMI format for the AIO machines
Date: Fri, 8 Mar 2013 07:50:10 +0000 [thread overview]
Message-ID: <20130308075009.GA18734@srcf.ucam.org> (raw)
In-Reply-To: <1362728670-3136-1-git-send-email-acelan.kao@canonical.com>
On Fri, Mar 08, 2013 at 03:44:30PM +0800, AceLan Kao wrote:
> static const struct key_entry dell_wmi_aio_keymap[] = {
> { KE_KEY, 0xc0, { KEY_VOLUMEUP } },
> { KE_KEY, 0xc1, { KEY_VOLUMEDOWN } },
> + { KE_KEY, 0xe030, { KEY_VOLUMEUP } },
> + { KE_KEY, 0xe02e, { KEY_VOLUMEDOWN } },
> + { KE_KEY, 0xe020, { KEY_MUTE } },
> + { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> + { KE_KEY, 0xe006, { KEY_BRIGHTNESSUP } },
> + { KE_KEY, 0xe005, { KEY_BRIGHTNESSDOWN } },
> + { KE_KEY, 0xe00b, { KEY_SWITCHVIDEOMODE } },
This is starting to look awfully like the keymap in dell-wmi.c. There's
probably an argument for merging them at the source level, even if it
ends up duplicated in both drivers.
> + if (dell_wmi_aio_event_check(obj->buffer.pointer,
> + obj->buffer.length)) {
Are we guaranteed that the old events will never look like this?
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2013-03-08 7:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-08 7:44 [PATCH] dell: add new dell WMI format for the AIO machines AceLan Kao
2013-03-08 7:50 ` Matthew Garrett [this message]
2013-03-08 8:19 ` AceLan Kao
2013-03-08 10:40 ` Colin Ian King
-- strict thread matches above, loose matches on Subject: below --
2013-03-07 2:48 AceLan Kao
2013-03-07 10:17 ` Colin Ian King
2013-03-06 7:51 AceLan Kao
2013-03-06 8:33 ` Colin Ian King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130308075009.GA18734@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=acelan.kao@canonical.com \
--cc=colin.king@canonical.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox