From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3 1/1] Introduce Intel RAPL cooling device driver Date: Tue, 9 Apr 2013 09:07:41 -0700 Message-ID: <20130409160741.GA8080@kroah.com> References: <1365511578-30453-1-git-send-email-jacob.jun.pan@linux.intel.com> <1365511578-30453-2-git-send-email-jacob.jun.pan@linux.intel.com> <20130409152638.GA3033@kroah.com> <1365522817.6865.33.camel@joe-AO722> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:58819 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936191Ab3DIQHq (ORCPT ); Tue, 9 Apr 2013 12:07:46 -0400 Received: by mail-pa0-f42.google.com with SMTP id kq13so3872314pab.29 for ; Tue, 09 Apr 2013 09:07:45 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1365522817.6865.33.camel@joe-AO722> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Joe Perches Cc: Jacob Pan , LKML , Platform Driver , Matthew Garrett , Zhang Rui , Rafael Wysocki , Len Brown , Srinivas Pandruvada , Arjan van de Ven On Tue, Apr 09, 2013 at 08:53:37AM -0700, Joe Perches wrote: > On Tue, 2013-04-09 at 08:26 -0700, Greg Kroah-Hartman wrote: > > On Tue, Apr 09, 2013 at 05:46:18AM -0700, Jacob Pan wrote: > > > +#define DEBUG > > Why? I think you need to remove this line :) > > Some people like their dev_dbg statements to > be emitted all the time. Those people should not be submitting new drivers for inclusion in the kernel tree.