From mboxrd@z Thu Jan 1 00:00:00 1970 From: Luis Henriques Subject: Re: [PATCH 3.8-stable] msi-wmi: Fix memory leak Date: Thu, 11 Apr 2013 13:41:11 +0100 Message-ID: <20130411124111.GB13039@hercules> References: <516018d4.41e1440a.5308.fffff9f2@mx.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:43421 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752764Ab3DKMlQ (ORCPT ); Thu, 11 Apr 2013 08:41:16 -0400 Content-Disposition: inline In-Reply-To: <516018d4.41e1440a.5308.fffff9f2@mx.google.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: jhbird.choi@gmail.com Cc: Anisse Astier , Matthew Garrett , Maxim Mikityanskiy , stable@vger.kernel.org, platform-driver-x86@vger.kernel.org, "Lee, Chun-Yi" , Jonghwan Choi On Sat, Apr 06, 2013 at 09:43:57PM +0900, jhbird.choi@gmail.com wrote: > From: Maxim Mikityanskiy > > This patch looks like it should be in the 3.8-stable tree, should we apply > it? I believe this is also applicable to 3.5 kernels. I'm queuing it. Cheers, -- Luis > > ------------------ > > From: "Maxim Mikityanskiy " > > commit 51c94491c82c3d9029f6e87a1a153db321d88e35 upstream > > Fix memory leak - don't forget to kfree ACPI object when returning from > msi_wmi_notify() after suppressing key event. > > Signed-off-by: Maxim Mikityanskiy > Acked-by: Anisse Astier > Signed-off-by: Lee, Chun-Yi > Signed-off-by: Matthew Garrett > Signed-off-by: Jonghwan Choi > --- > drivers/platform/x86/msi-wmi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/platform/x86/msi-wmi.c b/drivers/platform/x86/msi-wmi.c > index 2264331..b96766b 100644 > --- a/drivers/platform/x86/msi-wmi.c > +++ b/drivers/platform/x86/msi-wmi.c > @@ -176,7 +176,7 @@ static void msi_wmi_notify(u32 value, void *context) > pr_debug("Suppressed key event 0x%X - " > "Last press was %lld us ago\n", > key->code, ktime_to_us(diff)); > - return; > + goto msi_wmi_notify_exit; > } > last_pressed[key->code - SCANCODE_BASE] = cur; > > @@ -195,6 +195,8 @@ static void msi_wmi_notify(u32 value, void *context) > pr_info("Unknown key pressed - %x\n", eventcode); > } else > pr_info("Unknown event received\n"); > + > +msi_wmi_notify_exit: > kfree(response.pointer); > } > > -- > 1.7.10.4 > > -- > To unsubscribe from this list: send the line "unsubscribe stable" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html