From: Jonathan Woithe <jwoithe@just42.net>
To: Jean Delvare <jdelvare@suse.de>
Cc: platform-driver-x86@vger.kernel.org,
Matthew Garrett <matthew.garrett@nebula.com>,
jwoithe@just42.net
Subject: Re: [PATCH 1/2] fujitsu-laptop: Drop unneeded include
Date: Mon, 17 Mar 2014 22:24:15 +1030 [thread overview]
Message-ID: <20140317115415.GA1258@marvin.atrad.com.au> (raw)
In-Reply-To: <20140317120022.538264f9@endymion.delvare>
Acked-by: Jonathan Woithe <jwoithe@just42.net>
On Mon, Mar 17, 2014 at 12:00:22PM +0100, Jean Delvare wrote:
> The fujitsu-laptop driver includes <linux/video_output.h> but doesn't
> call any of its functions. Drop the unneeded include to avoid
> unnecessary driver rebuilds.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Jonathan Woithe <jwoithe@just42.net>
> Cc: Matthew Garrett <matthew.garrett@nebula.com>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 1 -
> 1 file changed, 1 deletion(-)
>
> --- linux-3.14-rc6.orig/drivers/platform/x86/fujitsu-laptop.c 2014-03-17 11:31:04.273862743 +0100
> +++ linux-3.14-rc6/drivers/platform/x86/fujitsu-laptop.c 2014-03-17 11:31:19.961145958 +0100
> @@ -66,7 +66,6 @@
> #include <linux/backlight.h>
> #include <linux/input.h>
> #include <linux/kfifo.h>
> -#include <linux/video_output.h>
> #include <linux/platform_device.h>
> #include <linux/slab.h>
> #if defined(CONFIG_LEDS_CLASS) || defined(CONFIG_LEDS_CLASS_MODULE)
>
>
> --
> Jean Delvare
> SUSE L3 Support
prev parent reply other threads:[~2014-03-17 11:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 11:00 [PATCH 1/2] fujitsu-laptop: Drop unneeded include Jean Delvare
2014-03-17 11:54 ` Jonathan Woithe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140317115415.GA1258@marvin.atrad.com.au \
--to=jwoithe@just42.net \
--cc=jdelvare@suse.de \
--cc=matthew.garrett@nebula.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox