From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: Hans de Goede <hdegoede@redhat.com>, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH v2 0/1] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on X240 / T440 / T540
Date: Wed, 9 Apr 2014 21:12:21 -0300 [thread overview]
Message-ID: <20140410001221.GA23977@khazad-dum.debian.net> (raw)
In-Reply-To: <20140409182758.GA3196@srcf.ucam.org>
On Wed, 09 Apr 2014, Matthew Garrett wrote:
> On Wed, Apr 09, 2014 at 03:03:01PM -0300, Henrique de Moraes Holschuh wrote:
> > On Wed, 09 Apr 2014, Hans de Goede wrote:
> > > This patch seems to have fallen through the cracks, so here is a resend.
> >
> > Sort of. There was a doubt about one of the keycodes.
>
> I think I'm ok with the keycode.
Ok. Now, provided that it doesn't clash with the other thinkpads (in which
case we'd just add selective keymaps), we can merge.
Heck, we can fix that later too, it doesn't count as an ABI break, these
keymaps are _already_ configurable from userspace _and_ usually reconfigured
by userspace, the driver just tries to provide sane defaults. So...
Acked-by: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2014-04-10 0:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-09 9:46 [PATCH v2 0/1] thinkpad_acpi: Add mappings for F9 - F12 hotkeys on X240 / T440 / T540 Hans de Goede
2014-04-09 9:46 ` [PATCH v2] " Hans de Goede
2014-04-09 18:03 ` [PATCH v2 0/1] " Henrique de Moraes Holschuh
2014-04-09 18:27 ` Matthew Garrett
2014-04-10 0:12 ` Henrique de Moraes Holschuh [this message]
2014-04-10 8:17 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410001221.GA23977@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=hdegoede@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox