From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
To: Jan van den Berg <janvdberg@gmail.com>
Cc: Darren Hart <dvhart@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: thinkpad_acpi.c: fixed spacing coding style issue
Date: Wed, 17 Sep 2014 09:48:35 -0300 [thread overview]
Message-ID: <20140917124835.GA30371@khazad-dum.debian.net> (raw)
In-Reply-To: <CAA-PxD-e-SGQO3eO0PLn9GVdSwXOT=y+Ycsxkm7KtfKhbCcNdw@mail.gmail.com>
On Wed, 17 Sep 2014, Jan van den Berg wrote:
> I will try and make _real_ contribution next time. (With this being my
> first ever submission to the kernel: at least now I understand the kernel
> workflow.)
There's nothing wrong with your patch by itself. And git does try to help
us take such patches (there's "git blame -w")... but ignoring whitespace
changes doesn't always work as well as one would like.
That said, Darren has already queued your patch, and I am _not_ going to ask
him to drop it. So, as far as I'm concerned, the patch has been accepted,
and that's it.
--
"One disk to rule them all, One disk to find them. One disk to bring
them all and in the darkness grind them. In the Land of Redmond
where the shadows lie." -- The Silicon Valley Tarot
Henrique Holschuh
next prev parent reply other threads:[~2014-09-17 12:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-16 22:01 [PATCH] x86: thinkpad_acpi.c: fixed spacing coding style issue Jan van den Berg
2014-09-16 22:12 ` Darren Hart
2014-09-17 10:45 ` Henrique de Moraes Holschuh
[not found] ` <CAA-PxD-e-SGQO3eO0PLn9GVdSwXOT=y+Ycsxkm7KtfKhbCcNdw@mail.gmail.com>
2014-09-17 12:48 ` Henrique de Moraes Holschuh [this message]
2014-09-17 16:20 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140917124835.GA30371@khazad-dum.debian.net \
--to=hmh@hmh.eng.br \
--cc=dvhart@infradead.org \
--cc=janvdberg@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox