From: "Pali Rohár" <pali.rohar@gmail.com>
To: Darren Hart <dvhart@infradead.org>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>,
kbuild@01.org, Gabriele Mazzotta <gabriele.mzt@gmail.com>
Subject: Re: [patch] dell-laptop: fix kbd_timeout handling
Date: Thu, 4 Dec 2014 10:42:37 +0100 [thread overview]
Message-ID: <201412041042.37888@pali> (raw)
In-Reply-To: <20141203073324.GA8568@vmdeb7>
[-- Attachment #1: Type: Text/Plain, Size: 1191 bytes --]
On Wednesday 03 December 2014 08:33:25 Darren Hart wrote:
> On Wed, Dec 03, 2014 at 01:01:59PM +0300, Dan Carpenter wrote:
> > The original code had a static checker warning:
> > drivers/platform/x86/dell-laptop.c:1389
> > kbd_led_timeout_store() warn: this array is probably
> > non-NULL. 'quirks->kbd_timeouts'
> >
> > This warning does indicate a bug. I have added a
> > .needs_kbd_timeouts flag which is true if the
> > .kbd_timeouts[] array has been declared. Otherwise, in the
> > original code the quirk_dell_vostro_v130 struct didn't
> >
> > have .kbd_timeouts[] declared so the loop:
> > for (i = 0; quirks->kbd_timeouts[i] != -1; i++) {
> >
> > Would have read beyond the end of the struct with
> > unpredictable results.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> Thanks Dan,
>
> Pali, any objections?
>
> Dan, any objection to Pali rolling this into another revision?
> No point in introducing the bug to next and mainline.
>
> Thanks,
No problem from my side. This quirks code was done by Gabriele to
fix BIOS problems on some laptops.
Gabriele, any objections?
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2014-12-04 9:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1417597233.14672.2.camel@Pali-Nokia-N900>
2014-12-03 10:01 ` [patch] dell-laptop: fix kbd_timeout handling Dan Carpenter
2014-12-03 7:33 ` Darren Hart
2014-12-04 8:30 ` Dan Carpenter
2014-12-04 9:42 ` Pali Rohár [this message]
2014-12-04 10:58 ` Gabriele Mazzotta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201412041042.37888@pali \
--to=pali.rohar@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=dvhart@infradead.org \
--cc=gabriele.mzt@gmail.com \
--cc=kbuild@01.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox