From mboxrd@z Thu Jan 1 00:00:00 1970 From: Darren Hart Subject: Re: [PATCH 2/3] toshiba_acpi: Fix typos in pr_* messages from USB Fleep Functions Date: Fri, 27 Mar 2015 19:58:55 -0700 Message-ID: <20150328025855.GB37152@fury.dvhart.com> References: <1427490565-6363-1-git-send-email-coproscefalo@gmail.com> <1427490565-6363-3-git-send-email-coproscefalo@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from bombadil.infradead.org ([198.137.202.9]:32826 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbbC1C64 (ORCPT ); Fri, 27 Mar 2015 22:58:56 -0400 Content-Disposition: inline In-Reply-To: <1427490565-6363-3-git-send-email-coproscefalo@gmail.com> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Azael Avalos Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org On Fri, Mar 27, 2015 at 03:09:25PM -0600, Azael Avalos wrote: > This patch fixes typos in the pr_* messages from the USB Sleep > Functions. > > Signed-off-by: Azael Avalos > --- > drivers/platform/x86/toshiba_acpi.c | 16 ++++++++-------- > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/platform/x86/toshiba_acpi.c b/drivers/platform/x86/toshiba_acpi.c > index 595f12c..3bb456c 100644 > --- a/drivers/platform/x86/toshiba_acpi.c > +++ b/drivers/platform/x86/toshiba_acpi.c > @@ -955,11 +955,11 @@ static int toshiba_usb_rapid_charge_get(struct toshiba_acpi_dev *dev, > status = tci_raw(dev, in, out); > sci_close(dev); > if (ACPI_FAILURE(status) || out[0] == TOS_FAILURE) { > - pr_err("ACPI call to get USB S&C battery level failed\n"); > + pr_err("ACPI call to get USB Rapid Charge failed\n"); > return -EIO; > } else if (out[0] == TOS_NOT_SUPPORTED || > out[0] == TOS_INPUT_DATA_ERROR) { > - pr_info("USB Sleep and Charge not supported\n"); > + pr_info("USB Rapid Charge not supported\n"); This is a name change, not a typo fix. You added a comment in 1/3 using Sleep and Charge, should this patch perhaps come first? Or... hrm... this is using the correct name for each state, and 1/3 added Sleep and Charge to the correct one... right, probably just need a better commit message. Not a type, but fixing the messages reporting the wrong states. -- Darren Hart Intel Open Source Technology Center