From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH v2 1/3] platform: x86: dell-rbtn: Dell Airplane Mode Switch driver Date: Wed, 29 Apr 2015 18:28:40 +0200 Message-ID: <20150429162840.GN24346@pali> References: <1416755361-17357-1-git-send-email-pali.rohar@gmail.com> <37641224.OJKZVtGCPV@xps13> <20150429130840.GI24346@pali> <2564950.goQdGu3mlb@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-wi0-f176.google.com ([209.85.212.176]:37500 "EHLO mail-wi0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753599AbbD2Q2o (ORCPT ); Wed, 29 Apr 2015 12:28:44 -0400 Content-Disposition: inline In-Reply-To: <2564950.goQdGu3mlb@xps13> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Gabriele Mazzotta Cc: Matthew Garrett , Darren Hart , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Alex Hung On Wednesday 29 April 2015 15:57:58 Gabriele Mazzotta wrote: > On Wednesday 29 April 2015 15:08:40 Pali Roh=C3=A1r wrote: > > On Wednesday 29 April 2015 12:30:32 Gabriele Mazzotta wrote: > > > On Wednesday 29 April 2015 11:51:04 Pali Roh=C3=A1r wrote: > > > > This is an ACPI driver for Dell laptops which receive HW switch= events. > > > > It exports rfkill device dell-rbtn which provide correct hard r= fkill state. > > > >=20 > > > > Alex Hung added code for supporting Dell laptops which have tog= gle button > > > > instead HW slider switch. On these laptops toggle button event = is reported > > > > by new input device (instead rfkill) as they do not have hw rad= io switch. > > > >=20 > > > > It looks like those are two different functions (rfkill, input = device), but > > > > Dell BIOS exports them via same ACPI device and uses same ACPI = functions. > > > > So code is in one kernel driver. > > >=20 > > > I made a patch some time ago that I've just adapted. It allows to > > > prefer RBTN_SLIDER over RBTN_TOGGLE. The main reason why I'd like= to > > > have the hardware switch is that the BIOS doesn't alter the soft = state > > > of the devices. This comes in handy when the function key control= s > > > multiple radio devices. > > >=20 > >=20 > > Now I'm thinking... is't this bug in wifi kernel driver (which expo= rts > > phy rfkill)? Or problem somewhere else (userspace or kernel)? >=20 > What is the presumed bug you are referring to? The fact that the soft= state > doesn't change? Can you remind me whats the problem on your laptop? --=20 Pali Roh=C3=A1r pali.rohar@gmail.com