From: Darren Hart <dvhart@infradead.org>
To: "Powell, Michael" <Michael_Powell@mentor.com>
Cc: "jlee@suse.com" <jlee@suse.com>,
"platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>
Subject: Re: [PATCH RESEND] acer-wmi: No rfkill on HP wifi
Date: Wed, 5 Aug 2015 13:58:21 -0700 [thread overview]
Message-ID: <20150805205821.GB38348@vmdeb7> (raw)
In-Reply-To: <20150805205421.GA38348@vmdeb7>
On Wed, Aug 05, 2015 at 01:54:21PM -0700, Darren Hart wrote:
> On Sun, Aug 02, 2015 at 10:59:29PM +0000, Powell, Michael wrote:
> > Prevents acer-wmi from blocking wifi on HP Omen 15 laptops
>
> Wow, you managed to miss both my automated scans for patches that fail
> to Cc the maintainer :-) Patchwork caught it though.
>
> Please Cc the maintainer listed in MAINTAINERS in the future per
> Documentation/SubmittingPatches, section 5.
>
> >
> > Signed-off-by: Michael Powell <michael_powell@mentor.com>
> > ---
> > drivers/platform/x86/acer-wmi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/platform/x86/acer-wmi.c
> > b/drivers/platform/x86/acer-wmi.c
> > index 3ac29a1..3ad8077 100644
> > --- a/drivers/platform/x86/acer-wmi.c
> > +++ b/drivers/platform/x86/acer-wmi.c
> > @@ -807,6 +807,7 @@ static const struct acpi_device_id norfkill_ids[]
> > __initconst = {
> > { "IBM0068", 0},
> > { "LEN0068", 0},
> > { "SNY5001", 0}, /* sony-laptop in charge */
> > + { "HPQ6001", 0},
> > { "", 0},
> > };
>
> I haven't determined the reason yet, but when saving this to apply, I get an
> encoded blob of text instead of the patch. How did you send this email?
And when pulling it down from Patchwork it has embedded ^M characters which
cause it to fail to apply with:
fatal: corrupt patch at line 17
Please resubmit after sending to yourself and verifying you can apply the patch.
--
Darren Hart
Intel Open Source Technology Center
prev parent reply other threads:[~2015-08-05 20:57 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 21:36 [PATCH] acer-wmi: No rfkill on HP wifi Powell, Michael
2015-08-02 22:59 ` [PATCH RESEND] " Powell, Michael
2015-08-05 20:54 ` Darren Hart
2015-08-05 20:58 ` Darren Hart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150805205821.GB38348@vmdeb7 \
--to=dvhart@infradead.org \
--cc=Michael_Powell@mentor.com \
--cc=jlee@suse.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox