From: Darren Hart <dvhart@infradead.org>
To: "Chakravarty, Souvik K" <souvik.k.chakravarty@intel.com>
Cc: "platform-driver-x86@vger.kernel.org"
<platform-driver-x86@vger.kernel.org>,
"Kasagar, Srinidhi" <srinidhi.kasagar@intel.com>,
"Zha, Qipeng" <qipeng.zha@intel.com>
Subject: Re: [PATCH v2 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry
Date: Sat, 10 Oct 2015 11:38:29 -0700 [thread overview]
Message-ID: <20151010183829.GA23749@malice.jf.intel.com> (raw)
In-Reply-To: <5F7315E704FA0841B5DFCE90329B2BB42AD0C76E@BGSMSX102.gar.corp.intel.com>
On Fri, Oct 09, 2015 at 04:31:40AM +0000, Chakravarty, Souvik K wrote:
> Hi Darren,
>
> I am a bit confused as checkpatch that I pulled from Linus' tree gave me all clear.
> Can you please send me the log, because I have a clean checkpatch report at my end.
>
Sure, using checkpatch.pl from Linux v4.3-rc4:
$ scripts/checkpatch.pl ~/incoming/*mbox
------------------------------------------------------------------------------------
/home/dvhart/incoming/PATCH_v2_1-4_platform-x86_Add_Intel_Telemetry_Core_Driver.mbox
------------------------------------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#51:
new file mode 100644
WARNING: Comparisons should place the constant on the right side of the test
#645: FILE: drivers/platform/x86/intel_telemetry_core.c:437:
+ if (TELEM_PSS == telem_unit)
WARNING: Comparisons should place the constant on the right side of the test
#648: FILE: drivers/platform/x86/intel_telemetry_core.c:440:
+ else if (TELEM_IOSS == telem_unit)
total: 0 errors, 3 warnings, 611 lines checked
/home/dvhart/incoming/PATCH_v2_1-4_platform-x86_Add_Intel_Telemetry_Core_Driver.mbox has style problems, please review.
-------------------------------------------------------------------------------------------------
/home/dvhart/incoming/PATCH_v2_2-4_platform-x86_Add_Intel_telemetry_platform_device_&_driver.mbox
-------------------------------------------------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#211:
new file mode 100644
WARNING: Block comments use * on subsequent lines
#318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103:
+/* The following counters are programmed by default during setup.
+ Only 20 allocated to kernel driver */
WARNING: Block comments use a trailing */ on a separate line
#318: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:103:
+ Only 20 allocated to kernel driver */
WARNING: Comparisons should place the constant on the right side of the test
#388: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:173:
+ if (TELEM_PSS == telem_unit)
WARNING: Comparisons should place the constant on the right side of the test
#390: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:175:
+ else if (TELEM_IOSS == telem_unit)
WARNING: Comparisons should place the constant on the right side of the test
#421: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:206:
+ if ((len > 0) && (NULL == evtmap))
WARNING: Comparisons should place the constant on the right side of the test
#431: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:216:
+ if ((len > 0) && (NULL == evtmap))
WARNING: Comparisons should place the constant on the right side of the test
#509: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:294:
+ if (TELEM_RESET == action) {
WARNING: Comparisons should place the constant on the right side of the test
#539: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:324:
+ if (TELEM_UPDATE == action) {
WARNING: Comparisons should place the constant on the right side of the test
#571: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:356:
+ if (TELEM_ADD == action) {
WARNING: Comparisons should place the constant on the right side of the test
#642: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:427:
+ if (TELEM_RESET == action) {
WARNING: Comparisons should place the constant on the right side of the test
#669: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:454:
+ if (TELEM_UPDATE == action) {
WARNING: Comparisons should place the constant on the right side of the test
#699: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:484:
+ if (TELEM_ADD == action) {
WARNING: Comparisons should place the constant on the right side of the test
#1204: FILE: drivers/platform/x86/intel_telemetry_pltdrv.c:989:
+ if (NULL == verbosity)
total: 0 errors, 14 warnings, 1371 lines checked
/home/dvhart/incoming/PATCH_v2_2-4_platform-x86_Add_Intel_telemetry_platform_device_&_driver.mbox has style problems, please review.
-------------------------------------------------------------------------------------------
/home/dvhart/incoming/PATCH_v2_3-4_platform-x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox
-------------------------------------------------------------------------------------------
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#46:
new file mode 100644
total: 0 errors, 1 warnings, 1094 lines checked
/home/dvhart/incoming/PATCH_v2_3-4_platform-x86_Add_Intel_Telemetry_Debugfs_interfaces.mbox has style problems, please review.
-------------------------------------------------------------------------------------------------------------
/home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig-MAINTAINERS_changes_for_Intel_Telemetry.mbox
-------------------------------------------------------------------------------------------------------------
total: 0 errors, 0 warnings, 36 lines checked
/home/dvhart/incoming/PATCH_v2_4-4_platform-x86_Makefile-Kconfig-MAINTAINERS_changes_for_Intel_Telemetry.mbox has no obvious style problems and is ready for submission.
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-10-10 18:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-22 9:01 [PATCH v2 4/4] platform:x86: Makefile/Kconfig/MAINTAINERS changes for Intel Telemetry Souvik Kumar Chakravarty
2015-10-08 16:52 ` Darren Hart
2015-10-09 4:31 ` Chakravarty, Souvik K
2015-10-10 18:38 ` Darren Hart [this message]
2015-10-12 4:36 ` Chakravarty, Souvik K
-- strict thread matches above, loose matches on Subject: below --
2015-10-12 9:33 Souvik Kumar Chakravarty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151010183829.GA23749@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=souvik.k.chakravarty@intel.com \
--cc=srinidhi.kasagar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox