From: Darren Hart <dvhart@infradead.org>
To: "Pali Rohár" <pali.rohar@gmail.com>
Cc: Andy Lutomirski <luto@kernel.org>,
platform-driver-x86@vger.kernel.org,
Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH v2] dell-wmi: Improve unknown hotkey handling
Date: Mon, 30 Nov 2015 10:27:38 -0800 [thread overview]
Message-ID: <20151130182738.GA30553@malice.jf.intel.com> (raw)
In-Reply-To: <20151123194710.GJ24147@pali>
On Mon, Nov 23, 2015 at 08:47:10PM +0100, Pali Rohár wrote:
> On Friday 20 November 2015 17:27:00 Andy Lutomirski wrote:
> > + if (keycode == KEY_RESERVED) {
> > + pr_info("firmware scancode %d maps to unrecognized keycode %d\n",
> > + bios_entry->scancode, bios_entry->keycode);
> > + continue;
> > + }
>
> Please use "0x%x" instead "%d" for those scan and key codes. Other parts
> in driver use "0x%x" so that new info message could be more confused if
> it has decimal codes...
>
> With that fix, you can add my:
> Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Andy, will you be resending with this change?
--
Darren Hart
Intel Open Source Technology Center
next prev parent reply other threads:[~2015-11-30 18:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-21 1:27 [PATCH v2] dell-wmi: Improve unknown hotkey handling Andy Lutomirski
2015-11-21 1:30 ` Andy Lutomirski
2015-11-23 14:56 ` Pali Rohár
2015-11-23 18:47 ` Darren Hart
2015-11-23 19:29 ` Andy Lutomirski
2015-11-23 19:47 ` Pali Rohár
2015-11-30 18:27 ` Darren Hart [this message]
2015-11-30 18:33 ` Andy Lutomirski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151130182738.GA30553@malice.jf.intel.com \
--to=dvhart@infradead.org \
--cc=luto@kernel.org \
--cc=mjg59@srcf.ucam.org \
--cc=pali.rohar@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox