Re: [PATCH V8 1/2] intel_pmc_ipc: update acpi resource structure for Punit

[Darren Hart <dvhart@infradead.org>]

On Tue, Dec 08, 2015 at 03:19:17PM +0200, Andy Shevchenko wrote:
> On Mon, 2015-12-07 at 15:45 -0800, Darren Hart wrote:
> > On Tue, Dec 08, 2015 at 12:55:04AM +0800, Qipeng Zha wrote:
> > > BIOS restructure exported memory resources for Punit
> > > in acpi table, So update resources for Punit.
> > > 
> > > Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>
> > 
> > Thank you for the update Qipeng. I will review shortly.
> > 
> > +Andriy who originally raised the concern over the ACPI resource
> > assumptions in
> > the previous version. Andriy, this resource allocation looks to be a
> > substantial
> > improvement to me. Do you have any further concerns?
> 
> So, regarding to the second patch
> 
> 1. In excerpts like following
> 
> if (IS_ERR(addr)) {
> 		dev_err(&pdev->dev, "Failed to map resouce for BIOS
> DATA\n");
> 		return PTR_ERR(addr);
> 	}
> 
> No need to have an error message. Core already has something to print
> at that point.

Ah, so neither the DATA nor the INTER messages are necessary. I suppose this
means you can ignore my response on better wording.

-- 
Darren Hart
Intel Open Source Technology Center