Re: [PATCH] Keyboard backlight control for some Vaio Fit models

[Mattia Dongili <malattia@linux.it>]

On Tue, Dec 15, 2015 at 10:01:28AM -0800, Darren Hart wrote:
> On Mon, Dec 14, 2015 at 09:12:32PM -0800, Mattia Dongili wrote:
> > SVF1521P6EW, SVF1521DCXW, SVF13N1L2ES and likely most SVF*.
> > do not expose separate timeout controls in auto mode.
> > 
> > Signed-off-by: Dominik Matta <dominik@matta.sk>
> > Signed-off-by: Mattia Dongili <malattia@linux.it>
> > ---
> >  drivers/platform/x86/sony-laptop.c | 65 ++++++++++++++++++++++++++------------
> >  1 file changed, 45 insertions(+), 20 deletions(-)
> > 
> 
> Thanks Mattia,
> 
> The changes look fine.
> 
> At some point we should address some of the style inconsistencies with this
> driver, but to nitpic on them for this patch wouldn't be productive. I've merged
> this patch - please consider the following for future work with the goal toward
> making the kernel code as consistent as possible to aid in legibility and
> maintainability.

Thanks Darren.

This driver needs many things, but yes, I'll keep in mind
these other guidelines for any future change.

Best,
-- 
mattia
:wq!