Re: [PATCH] intel-hid: new hid event driver for hotkeys

[Darren Hart <dvhart@infradead.org>]

On Thu, Dec 17, 2015 at 03:30:02PM +0800, Alex Hung wrote:
> This driver supports various hid events including hotkeys.
> Dell XPS 13 9350 requires it for wireless hotkey.
> 
> Andy Lutomirski contributed greatly to this driver.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>

Queued for testing.

Andy, please provide your Reviewed-by if you're happy with it.

Alex, just one question maybe you can answer quickly and save me some time
below:


> +static int intel_hid_pl_suspend_handler(struct device *device)
> +{
> +	intel_hid_set_enable(device, 0);
> +	return 0;
> +}
> +
> +static int intel_hid_pl_resume_handler(struct device *device)
> +{
> +	intel_hid_set_enable(device, 1);
> +	return 0;
> +}

Why not propagate the intel_hid_set_enable() return code? Is it because it just
doesn't really impact suspend/resume, even if we do get an error?

-- 
Darren Hart
Intel Open Source Technology Center