X86 platform drivers
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali.rohar@gmail.com>
To: Mario Limonciello <mario_limonciello@dell.com>
Cc: "Dominguez, Jared" <Jared_Dominguez@DELL.com>,
	Andy Lutomirski <luto@amacapital.net>,
	Darren Hart <dvhart@infradead.org>,
	Andy Lutomirski <luto@kernel.org>,
	"platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	Matthew Garrett <mjg59@srcf.ucam.org>
Subject: Re: [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake
Date: Fri, 22 Jan 2016 09:26:02 +0100	[thread overview]
Message-ID: <20160122082602.GK7192@pali> (raw)
In-Reply-To: <56A17306.3010503@dell.com>

On Thursday 21 January 2016 18:08:38 Mario Limonciello wrote:
> 
> 
> On 01/21/2016 04:17 AM, Pali Rohár wrote:
> > On Monday 23 November 2015 15:53:51 Pali Rohár wrote:
> >> On Saturday 21 November 2015 20:04:15 D. Jared Dominguez wrote:
> >>> On Fri, Nov 20, 2015 at 06:12:58PM -0600, Andy Lutomirski wrote:
> >>>> Jared, want to give us some guidance as to whether this code is
> >>>> correct at all and, if so, whether we should actually send a
> >>>> KEY_RFKILL event from dell-wmi when the key is pressed?
> >>>>
> >>>> IOW, should we allow dell-wmi to handle rfkill or should we wait for
> >>>> the other mechanism?
> >>>>
> >>>> --Andy
> >>> I'm adding Mario since he's worked on our client systems much longer and
> >>> knows more about the correct behavior for our hotkeys. I've not yet read
> >>> through any of our documentation about our hotkey behavior so wouldn't be as
> >>> qualified to answer that. Note that both Mario and I are on vacation until
> >>> the 30th, so he may not reply until then.
> >>>
> >>> --Jared
> >>>
> >> Jared, thanks for your input! When you or Mario are back from vacation,
> >> can you look at it? Or if you do not have much time, can you provide
> >> documentation (or some snippets), so somebody else can update driver to
> >> work correctly?
> > Hi Jared & Mario, I believe you are back from vacation, can you look at it?
> >
> Pali,
> 
> I understand that intel-hid will be making it in at this point.  If I'm
> not mistaken, it should be handling this portion.

Hi Mario! Thats truth, but we still needs to know all codes which
dell-wmi should ignore (because they will be handled by intel-hid).

Currently Andy's patch adds three codes which are not specified in
vendor-specific DMI table.

Do you such table of key events which can ACPI/BIOS/WMI send to OS?

-- 
Pali Rohár
pali.rohar@gmail.com

  parent reply	other threads:[~2016-01-22  8:26 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-14  5:49 [PATCH 0/3] dell_wmi: XPS 13 Skylake support and misc stuff Andy Lutomirski
2015-11-14  5:49 ` [PATCH 1/3] dell_wmi: Support new hotkeys on the XPS 13 Skylake Andy Lutomirski
2015-11-14  9:27   ` Pali Rohár
2015-11-14 15:48     ` Andy Lutomirski
2015-11-14 16:13       ` Pali Rohár
     [not found]         ` <CALCETrWss=zCWhNkR2S_oi_m3W1xNO+UL_-uOnOVeLh5WHsDgQ@mail.gmail.com>
2015-11-17  8:36           ` Pali Rohár
2015-11-17 19:03             ` Andy Lutomirski
2015-11-18  3:44               ` Andy Lutomirski
2015-11-18 21:24   ` Andy Lutomirski
2015-11-19  8:19     ` Pali Rohár
2015-11-21  0:06   ` Darren Hart
2015-11-21  0:11     ` Pali Rohár
2015-11-21  0:12     ` Andy Lutomirski
2015-11-22  2:04       ` D. Jared Dominguez
2015-11-23 14:53         ` Pali Rohár
2016-01-21 10:17           ` Pali Rohár
2016-01-22  0:08             ` Mario Limonciello
2016-01-22  0:13               ` Andy Lutomirski
2016-01-22  8:26               ` Pali Rohár [this message]
2016-01-22 15:58                 ` Mario Limonciello
2016-01-22 17:11                   ` Pali Rohár
2015-11-14  5:49 ` [PATCH 2/3] dell_wmi: Use a C99-style array for bios_to_linux_keycode Andy Lutomirski
2015-11-14  9:30   ` Pali Rohár
2015-11-21  0:09   ` Darren Hart
2015-11-21  0:20     ` Pali Rohár
2015-11-21  0:26       ` Darren Hart
2015-11-21  0:28         ` Andy Lutomirski
2015-11-14  5:49 ` [PATCH 3/3] dell_wmi: Improve unknown hotkey handling Andy Lutomirski
2015-11-14  9:33   ` Pali Rohár
2015-11-17  1:35     ` Andy Lutomirski
2015-11-21  0:29       ` Darren Hart
2015-11-21  0:34         ` Andy Lutomirski
2015-11-21  0:41         ` Pali Rohár
2015-11-21  0:44           ` Andy Lutomirski
2015-11-21  0:14   ` Darren Hart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160122082602.GK7192@pali \
    --to=pali.rohar@gmail.com \
    --cc=Jared_Dominguez@DELL.com \
    --cc=dvhart@infradead.org \
    --cc=luto@amacapital.net \
    --cc=luto@kernel.org \
    --cc=mario_limonciello@dell.com \
    --cc=mjg59@srcf.ucam.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox