X86 platform drivers
 help / color / mirror / Atom feed
From: Darren Hart <dvhart@infradead.org>
To: Alex Hung <alex.hung@canonical.com>
Cc: platform-driver-x86@vger.kernel.org, luto@amacapital.net,
	pbludov@gmail.com
Subject: Re: [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap
Date: Sat, 30 Jan 2016 09:10:05 -0800	[thread overview]
Message-ID: <20160130171005.GC1749@malice.jf.intel.com> (raw)
In-Reply-To: <1453901700-20418-1-git-send-email-alex.hung@canonical.com>

On Wed, Jan 27, 2016 at 09:35:00PM +0800, Alex Hung wrote:
> intel_hid_keymap contains a duplicate entry for KEY_HOME and an
> incorrect HID index for KEY_PAGEDOWN
> 
> Reported-by: Pavel Bludov <pbludov@gmail.com>
> Signed-off-by: Alex Hung <alex.hung@canonical.com>

Thanks Alex, queued for 4.5 fixes.

> ---
>  drivers/platform/x86/intel-hid.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/intel-hid.c b/drivers/platform/x86/intel-hid.c
> index 20f0ad9..e20f23e 100644
> --- a/drivers/platform/x86/intel-hid.c
> +++ b/drivers/platform/x86/intel-hid.c
> @@ -41,8 +41,7 @@ static const struct key_entry intel_hid_keymap[] = {
>  	{ KE_KEY, 4, { KEY_HOME } },
>  	{ KE_KEY, 5, { KEY_END } },
>  	{ KE_KEY, 6, { KEY_PAGEUP } },
> -	{ KE_KEY, 4, { KEY_PAGEDOWN } },
> -	{ KE_KEY, 4, { KEY_HOME } },
> +	{ KE_KEY, 7, { KEY_PAGEDOWN } },
>  	{ KE_KEY, 8, { KEY_RFKILL } },
>  	{ KE_KEY, 9, { KEY_POWER } },
>  	{ KE_KEY, 11, { KEY_SLEEP } },
> -- 
> 2.5.0
> 
> 

-- 
Darren Hart
Intel Open Source Technology Center

      reply	other threads:[~2016-01-30 17:12 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-27 13:35 [PATCH] intel-hid: fix incorrect entries in intel_hid_keymap Alex Hung
2016-01-30 17:10 ` Darren Hart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160130171005.GC1749@malice.jf.intel.com \
    --to=dvhart@infradead.org \
    --cc=alex.hung@canonical.com \
    --cc=luto@amacapital.net \
    --cc=pbludov@gmail.com \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox