From: Mattia Dongili <malattia@linux.it>
To: Lawrence Yiu <lawyiu.dev@gmail.com>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] sony-laptop: Avoid oops on module unload for older laptops
Date: Tue, 22 Mar 2016 06:51:52 -0700 [thread overview]
Message-ID: <20160322135151.GA11220@taihen.jp> (raw)
In-Reply-To: <56EFB466.60008@gmail.com>
On Mon, Mar 21, 2016 at 01:44:22AM -0700, Lawrence Yiu wrote:
> Older VAIO laptops without the SN00 ACPI method will have the "handles"
> variable unset. Return early from sony_nc_function_cleanup when "handles"
> is null.
>
> Signed-off-by: Lawrence Yiu <lawyiu.dev@gmail.com>
Acked-by: Mattia Dongili <malattia@linux.it>
> ---
> drivers/platform/x86/sony-laptop.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
> index e9caa34..1dba359 100644
> --- a/drivers/platform/x86/sony-laptop.c
> +++ b/drivers/platform/x86/sony-laptop.c
> @@ -1446,6 +1446,9 @@ static void sony_nc_function_cleanup(struct platform_device *pd)
> {
> unsigned int i, result, bitmask, handle;
>
> + if (!handles)
> + return;
> +
Thank you, this is indeed necessary.
Given how long this sat around, it may be a good time to start
cleaning-up some legacy models support. Later anyway.
--
mattia
:wq!
next prev parent reply other threads:[~2016-03-22 13:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 8:44 [PATCH] sony-laptop: Avoid oops on module unload for older laptops Lawrence Yiu
2016-03-22 13:51 ` Mattia Dongili [this message]
2016-05-05 23:22 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160322135151.GA11220@taihen.jp \
--to=malattia@linux.it \
--cc=lawyiu.dev@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox