From: "Pali Rohár" <pali.rohar@gmail.com>
To: dvhart@infradead.org
Cc: Alex Hung <alex.hung@canonical.com>,
mjg59@srcf.ucam.org, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH][v2] dell-wmi: add a WMI event code for display on/off
Date: Fri, 17 Jun 2016 20:50:27 +0200 [thread overview]
Message-ID: <201606172050.27278@pali> (raw)
In-Reply-To: <1466135067-28566-1-git-send-email-alex.hung@canonical.com>
[-- Attachment #1: Type: Text/Plain, Size: 511 bytes --]
On Friday 17 June 2016 05:44:27 Alex Hung wrote:
> @@ -133,6 +133,9 @@ static const struct key_entry
> dell_wmi_keymap_type_0000[] __initconst = { /* Audio panel key */
> { KE_IGNORE, 0xe026, { KEY_RESERVED } },
>
> + /* Monitor On/Off Control key */
> + { KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
Darren, I would suggest small alignment (as for 0xe026):
{ KE_KEY, 0xe027, { KEY_DISPLAYTOGGLE } },
> { KE_IGNORE, 0xe026, { KEY_RESERVED } },
--
Pali Rohár
pali.rohar@gmail.com
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2016-06-17 18:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 3:44 [PATCH][v2] dell-wmi: add a WMI event code for display on/off Alex Hung
2016-06-17 18:19 ` Darren Hart
2016-06-17 18:50 ` Pali Rohár [this message]
2016-06-21 16:24 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201606172050.27278@pali \
--to=pali.rohar@gmail.com \
--cc=alex.hung@canonical.com \
--cc=dvhart@infradead.org \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox