From: "Pali Rohár" <pali.rohar@gmail.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Darren Hart <dvhart@infradead.org>,
Matthew Garrett <mjg59@srcf.ucam.org>,
platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform: x86: dell-laptop: use brightness_set_blocking for kbd_led_level_set
Date: Thu, 27 Oct 2016 12:33:48 +0200 [thread overview]
Message-ID: <20161027103348.GS12154@pali> (raw)
In-Reply-To: <20161026151744.16638-1-hdegoede@redhat.com>
On Wednesday 26 October 2016 17:17:44 Hans de Goede wrote:
> kbd_led_level_set uses dell_smbios call which block, so the kbd_led
> classdev should use the brightness_set_blocking callback.
>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Seems correct, Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
--
Pali Rohár
pali.rohar@gmail.com
next prev parent reply other threads:[~2016-10-27 14:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 15:17 [PATCH] platform: x86: dell-laptop: use brightness_set_blocking for kbd_led_level_set Hans de Goede
2016-10-27 10:33 ` Pali Rohár [this message]
2016-12-12 19:03 ` Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027103348.GS12154@pali \
--to=pali.rohar@gmail.com \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=mjg59@srcf.ucam.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox