From: "João Paulo Rechi Vita" <jprvita@gmail.com>
To: Corentin Chary <corentin.chary@gmail.com>,
Darren Hart <dvhart@infradead.org>
Cc: platform-driver-x86@vger.kernel.org,
acpi4asus-user@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linux@endlessm.com,
"João Paulo Rechi Vita" <jprvita@endlessm.com>
Subject: [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4}
Date: Thu, 26 Jan 2017 10:30:05 -0500 [thread overview]
Message-ID: <20170126153013.12753-1-jprvita@endlessm.com> (raw)
This quirk avoids the conflicting usage of ASUS_WMI_DEVID_WLAN_LED (0x00010002)
by both asus-wireless and asus-wmi on machines where the BIOS can't set and
record the wlan status (wlan_ctrl_by_user in asus-wmi.c). At the moment we have
six models using that quirk upstream, but there are another fifteen for which
we have downstream patches, and will send upstream unless we find a more
dynamic solution. We also expect this list to continue growing.
This series makes use of ASUS_WMI_DSTS_USER_BIT plus the status of the ASHS
device to skip asus_wmi_rfkill_init(). Since asus-wmi now needs to know the ASHS
_HIDs, I have moved device_ids[] to a new header file, asus-wireless.h. I'm not
sure if there are any best practices in the kernel community against having one
module including headers from a different module, but I wanted to avoid
duplicating this list or creating an ordering dependency between the modules.
Any advice on alternatives here are welcome.
PS: I don't think asus-wireless.h needs to also be listed in MAINTAINERS,
please correct me if I'm wrong.
João Paulo Rechi Vita (8):
Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA"
Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF"
Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA"
Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB"
Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW"
Revert "asus-wmi: Create quirk for airplane_mode LED"
asus-wireless: Export ids list
asus-wmi: Don't register rfkill if ASHS and user bit are present
drivers/platform/x86/asus-nb-wmi.c | 49 ++----------------------------------
drivers/platform/x86/asus-wireless.c | 15 +++++------
drivers/platform/x86/asus-wireless.h | 10 ++++++++
drivers/platform/x86/asus-wmi.c | 21 ++++++++++++----
drivers/platform/x86/asus-wmi.h | 1 -
5 files changed, 34 insertions(+), 62 deletions(-)
create mode 100644 drivers/platform/x86/asus-wireless.h
--
2.11.0
next reply other threads:[~2017-01-26 15:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-26 15:30 João Paulo Rechi Vita [this message]
2017-01-26 15:30 ` [PATCH 1/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UA" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 2/8] Revert "asus-wmi: Add quirk_no_rfkill_wapf4 for the Asus X456UF" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 3/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus Z550MA" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 4/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus U303LB" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 5/8] Revert "asus-wmi: Add quirk_no_rfkill for the Asus N552VW" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 6/8] Revert "asus-wmi: Create quirk for airplane_mode LED" João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 7/8] asus-wireless: Export ids list João Paulo Rechi Vita
2017-01-27 15:36 ` Andy Shevchenko
2017-02-01 12:23 ` João Paulo Rechi Vita
2017-02-04 15:35 ` Andy Shevchenko
2017-02-06 19:18 ` João Paulo Rechi Vita
2017-01-26 15:30 ` [PATCH 8/8] asus-wmi: Don't register rfkill if ASHS and user bit are present João Paulo Rechi Vita
2017-01-26 22:45 ` Joe Perches
2017-02-01 12:18 ` João Paulo Rechi Vita
2017-01-27 15:37 ` [PATCH 0/8] asus-wmi: Get rid of quirk_no_rfkill{,_wapf4} Andy Shevchenko
2017-02-01 12:21 ` João Paulo Rechi Vita
2017-02-04 15:05 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170126153013.12753-1-jprvita@endlessm.com \
--to=jprvita@gmail.com \
--cc=acpi4asus-user@lists.sourceforge.net \
--cc=corentin.chary@gmail.com \
--cc=dvhart@infradead.org \
--cc=jprvita@endlessm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@endlessm.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox