From: "Michał Kępień" <kernel@kempniu.pl>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH 0/4][RFC v2] fujitsu-laptop: fujitsu-laptop: clean ups from Alan Jenkins
Date: Fri, 3 Feb 2017 14:43:26 +0100 [thread overview]
Message-ID: <20170203134326.GA11947@ozzy.nask.waw.pl> (raw)
In-Reply-To: <20170131130741.GA6218@marvin.atrad.com.au>
> This series of patches for the fujitsu-laptop driver was originally
> submitted by Alan Jenkins in September 2009. For various reasons which are
> entirely my fault they were never acted upon. To remedy this they have been
> ported to the linux-platform-drivers-x86 git tree and compile-tested.
> Consequently this submission is a work in progress and is posted for
> comments and feedback.
>
> The patches are against git://git.infradead.org/linux-platform-drivers-x86.git
Jonathan,
I can now see why you were so reluctant to review this series :)
It is basically unreviewable in the state you posted it in: multiple
changes are packed into a single patch, commit messages are inaccurate
at best and omissive at worst.
In order to salvage Alan's efforts, I will rebase these patches on
dvhart/testing, split them up, write a proper commit message for each of
them and then repost with Alan as the author. This might take a while
though - to give you a rough idea, so far I split patch 1/4 into eight
separate patches (mostly churn, but still).
--
Best regards,
Michał Kępień
next prev parent reply other threads:[~2017-02-03 13:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 13:07 [PATCH 0/4][RFC v2] fujitsu-laptop: fujitsu-laptop: clean ups from Alan Jenkins Jonathan Woithe
2017-02-03 13:43 ` Michał Kępień [this message]
2017-02-03 23:25 ` Jonathan Woithe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170203134326.GA11947@ozzy.nask.waw.pl \
--to=kernel@kempniu.pl \
--cc=jwoithe@just42.net \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox