Re: [PATCH v9 4/4] platform/x86/dell-*: Call led_classdev_notify_brightness_hw_changed on kbd brightness change

["Pali Rohár" <pali.rohar@gmail.com>]

[-- Attachment #1: Type: Text/Plain, Size: 1029 bytes --]

On Sunday 19 March 2017 19:06:19 Hans de Goede wrote:
> Hi,
> 
> On 19-03-17 16:10, Pali Rohár wrote:
> > On Thursday 16 March 2017 11:55:35 Hans de Goede wrote:
> >> Changes in v9:
> >> -Only listen to type 0x0010 kbd-led events in dell-wmi.c, these
> >> only trigger on hotkey presses
> >> -Drop the new / previous brightness comparison from dell-laptop.c
> >> now that we only get events on hotkey presses it is no longer
> >> necessary ---
> > 
> > Hi! I'm really not sure if this change is correct there.
> > 
> > Now you are only listening for keypress "change kbd backlight", but
> > some dell machines could change keyboard backlight also in other
> > different situations, like attaching AC adapter. I guess (but I'm
> > not sure) this probably does not send keypress event.
> 
> I'm not aware of any Dells doing such a thing, if we encounter any
> then we can deal with that if and when that happens.

Ok, go ahead. We can fix issues when appear later.

-- 
Pali Rohár
pali.rohar@gmail.com

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 198 bytes --]