Re: [PATCH 1/1] asus-nb-wmi: Add wapf4 quirk for the X302UA

[Darren Hart <dvhart@infradead.org>]

On Tue, Apr 04, 2017 at 07:35:00PM +0300, Santeri Toivonen wrote:
> Asus laptop X302UA starts up with Wi-Fi disabled,
> without a way to enable it. Set wapf=4 to fix the problem.
> 
> Signed-off-by: Santeri Toivonen <santeri.toivonen@vatsul.com>
> ---
>  drivers/platform/x86/asus-nb-wmi.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/drivers/platform/x86/asus-nb-wmi.c
> b/drivers/platform/x86/asus-nb-wmi.c
> index dea98ffb6f60..1ae58d906536 100644
> --- a/drivers/platform/x86/asus-nb-wmi.c
> +++ b/drivers/platform/x86/asus-nb-wmi.c
> @@ -144,6 +144,15 @@ static const struct dmi_system_id asus_quirks[] = {
>  	},
>  	{
>  		.callback = dmi_matched,
> +		.ident = "ASUSTeK COMPUTER INC. X302UA",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "X302UA"),
> +		},
> +		.driver_data = &quirk_asus_wapf4,
> +	},
> +	{
> +		.callback = dmi_matched,
>  		.ident = "ASUSTeK COMPUTER INC. X401U",
>  		.matches = {
>  			DMI_MATCH(DMI_SYS_VENDOR, "ASUSTeK COMPUTER INC."),

Hi Santeri,

How are you preparing your patches? The context lines have an extra leading
space and fail to apply with git-am and patch.

Git will create properly formatted patches using the "git format-patch" command
after you have committed the change to your local repository. Alternatively you can use "diff -Nurp" directly, although that's much more tedious. Documentation/process/submitting-patches.rst has detailed instructions in "1) ``diff -up``".

-- 
Darren Hart
VMware Open Source Technology Center