From: "Michał Kępień" <kernel@kempniu.pl>
To: Jonathan Woithe <jwoithe@just42.net>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>, Harvey <harv@gmx.de>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection
Date: Tue, 31 Oct 2017 05:20:02 +0100 [thread overview]
Message-ID: <20171031042002.GA9788@larwa.localdomain> (raw)
In-Reply-To: <20171030121257.GA28737@marvin.atrad.com.au>
> > Do you consider this an important fix? We are at -rc7 now, I'm not
> > sure it's so critical. Tell me if you consider otherwise.
>
> I agree - from my perspective I wouldn't have thought it so critical as to
> push it out this late in the development cycle. It's not a regression as
> such and is largely cosmetic. Others may argue differently though.
I agree as well. The erroneous log messages will only be generated when
any rfkill device in the system is enabled or disabled, so IMHO this is
mostly a nuisance thus can be handled when convenient.
--
Best regards,
Michał Kępień
next prev parent reply other threads:[~2017-10-31 4:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-25 4:29 [PATCH] platform/x86: fujitsu-laptop: Fix radio LED detection Michał Kępień
2017-10-25 6:33 ` Jonathan Woithe
2017-10-25 13:11 ` Harvey
2017-10-27 16:49 ` Andy Shevchenko
2017-10-29 21:28 ` Michał Kępień
2017-10-30 11:21 ` Andy Shevchenko
2017-10-30 12:12 ` Jonathan Woithe
2017-10-30 14:13 ` Andy Shevchenko
2017-10-31 4:20 ` Michał Kępień [this message]
2017-10-31 10:54 ` Harvey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171031042002.GA9788@larwa.localdomain \
--to=kernel@kempniu.pl \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=harv@gmx.de \
--cc=jwoithe@just42.net \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox