From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph =?utf-8?Q?B=C3=B6hmwalder?= Subject: Re: [PATCH 1/3 v5] battery: Add the battery hooking API Date: Mon, 11 Dec 2017 18:52:58 +0100 Message-ID: <20171211175258.eewj7rmtqmk6hznf@localhost> References: <20171210180131.GA1865@thinkpad> <20171211120346.ast5ijqcxslfpbee@christoph-lap> <20171211163945.GA23317@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Received: from zimbra.linuxprofi.at ([93.83.54.199]:35480 "EHLO zimbra.linuxprofi.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750707AbdLKRxD (ORCPT ); Mon, 11 Dec 2017 12:53:03 -0500 Content-Disposition: inline In-Reply-To: <20171211163945.GA23317@thinkpad> Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Ognjen Galic Cc: "Rafael J. Wysocki" , Len Brown , Robert Moore , Lv Zheng , linux-acpi@vger.kernel.org, devel@acpica.org, Darren Hart , Andy Shevchenko , Henrique de Moraes Holschuh , platform-driver-x86@vger.kernel.org, ibm-acpi-devel@lists.sourceforge.net On Mon, Dec 11, 2017 at 05:39:45PM +0100, Ognjen Galic wrote: > The 80-char warning can be omitted if the line looks ugly when broken. > This is noted in the style guide. Indeed, you're right here. The line is just barely over 80 characters anyway, so it really doesn't matter here. > About the MAINTAINERS file, I don't know how, when or why to edit that > file so I did not touch it. That was just a warning about you moving drivers/acpi/battery.h to include/acpi/battery.h, which could potentially lead to an edit to MAINTAINERS being neccessary. I just double-checked this and the include/acpi/ path was already listed in the MAINTAINERS file, so you're good.