From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pali =?utf-8?B?Um9ow6Fy?= Subject: Re: [PATCH] Support tablet mode switch for Dell laptops Date: Thu, 18 Jan 2018 16:44:08 +0100 Message-ID: <20180118154408.eyke3dtn6zlcqphi@pali> References: <1516283990-3665-1-git-send-email-notmart@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <1516283990-3665-1-git-send-email-notmart@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Marco Martin Cc: linux-kernel@vger.kernel.org, mjg59@srcf.ucam.org, dvhart@infradead.org, andy@infradead.org, bhush94@gmail.com, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Thursday 18 January 2018 14:59:50 Marco Martin wrote: > - if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) > + if (event == 0xCC) { > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 1); > + input_sync(priv->input_dev); > + } else if (event == 0xCD) { > + input_report_switch(priv->input_dev, SW_TABLET_MODE, 0); > + input_sync(priv->input_dev); > + } else if (!sparse_keymap_report_event(priv->input_dev, event, 1, true)) Is not it possible to put 0xCC and 0xCD into sparse keymap table? Because IIRC sparse keymap was created just to avoid that big if-elseif-elseif-else blocks. > dev_info(&device->dev, "unknown event index 0x%x\n", > event); > } -- Pali Rohár pali.rohar@gmail.com