From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laszlo Toth Subject: [PATCH v2] platform/x86: dell-laptop: fix kbd_get_state's request value Date: Tue, 13 Feb 2018 20:27:39 +0100 Message-ID: <20180213192739.GA4985@laszlth> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:35798 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965315AbeBMT1n (ORCPT ); Tue, 13 Feb 2018 14:27:43 -0500 Received: by mail-wr0-f195.google.com with SMTP id 33so5742357wro.2 for ; Tue, 13 Feb 2018 11:27:43 -0800 (PST) Content-Disposition: inline Sender: platform-driver-x86-owner@vger.kernel.org List-ID: To: Matthew Garrett , Pali =?iso-8859-1?Q?Roh=E1r?= , Darren Hart , Andy Shevchenko , platform-driver-x86@vger.kernel.org, Mario Limonciello Commit 9862b43624a5 ("platform/x86: dell-laptop: Allocate buffer on heap rather than globally") broke one request, changed it back to the original value. Tested on a Dell E6540, backlight came back. Signed-off-by: Laszlo Toth --- Changes in v2: - split the fix and the function merge part drivers/platform/x86/dell-laptop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-laptop.c b/drivers/platform/x86/dell-laptop.c index 2a68f59..a37cff9 100644 --- a/drivers/platform/x86/dell-laptop.c +++ b/drivers/platform/x86/dell-laptop.c @@ -1279,7 +1279,7 @@ static int kbd_get_state(struct kbd_state *state) struct calling_interface_buffer buffer; int ret; - dell_fill_request(&buffer, 0, 0, 0, 0); + dell_fill_request(&buffer, 0x1, 0, 0, 0); ret = dell_send_request(&buffer, CLASS_KBD_BACKLIGHT, SELECT_KBD_BACKLIGHT); if (ret) -- 2.7.4