From: Jonathan Woithe <jwoithe@just42.net>
To: Micha?? K??pie?? <kernel@kempniu.pl>
Cc: Darren Hart <dvhart@infradead.org>,
Andy Shevchenko <andy@infradead.org>,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups
Date: Fri, 16 Feb 2018 21:27:47 +1030 [thread overview]
Message-ID: <20180216105747.GC25974@marvin.atrad.com.au> (raw)
In-Reply-To: <20180211210727.12130-1-kernel@kempniu.pl>
On Sun, Feb 11, 2018 at 10:07:20PM +0100, Micha?? K??pie?? wrote:
> The patch series contains miscellaneous cleanups which I think are worth
> getting done before splitting fujitsu-laptop into two separate modules.
> I am not 100% sure that all the changes in the last patch in this series
> actually help, so please speak your mind.
With the relatively minor comments about patch 6 I've posted about
separately, I'm happy with this patch set. Collectively these changes
improve the readability of the code and make its intent clearer.
> This patch series was tested on a Lifebook S7020. AFAICT it does not
> conflict with the recent draft patch from Jan-Marek Glogowski and may
> thus be applied independently.
I agree.
I'm interested to hear your thoughts in connection with my queries about
patch 6 before merging. That aside, I have no issues with this series.
Reviewed-by: Jonathan Woithe <jwoithe@just42.net>
Regards
jonathan
next prev parent reply other threads:[~2018-02-16 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-11 21:07 [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups Michał Kępień
2018-02-11 21:07 ` [PATCH 1/7] platform/x86: fujitsu-laptop: Unify local variable naming Michał Kępień
2018-02-11 21:07 ` [PATCH 2/7] platform/x86: fujitsu-laptop: Defer input device registration Michał Kępień
2018-02-11 21:07 ` [PATCH 3/7] platform/x86: fujitsu-laptop: Simplify error paths Michał Kępień
2018-02-11 21:07 ` [PATCH 4/7] platform/x86: fujitsu-laptop: Clearly distinguish module parameters Michał Kępień
2018-02-11 21:07 ` [PATCH 5/7] platform/x86: fujitsu-laptop: Do not include linux/slab.h Michał Kępień
2018-02-11 21:07 ` [PATCH 6/7] platform/x86: fujitsu-laptop: Define constants for backlight power control Michał Kępień
2018-02-16 10:50 ` Jonathan Woithe
2018-02-11 21:07 ` [PATCH 7/7] platform/x86: fujitsu-laptop: Clean up constants Michał Kępień
2018-02-11 21:20 ` Randy Dunlap
2018-02-11 21:35 ` Michał Kępień
2018-02-16 10:57 ` Jonathan Woithe [this message]
2018-02-16 19:37 ` [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups Darren Hart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180216105747.GC25974@marvin.atrad.com.au \
--to=jwoithe@just42.net \
--cc=andy@infradead.org \
--cc=dvhart@infradead.org \
--cc=kernel@kempniu.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox