From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v8 01/12] drivers: base: Unified device connection lookup Date: Tue, 20 Mar 2018 14:52:40 +0200 Message-ID: <20180320125240.GA25137@kuha.fi.intel.com> References: <20180314131215.70833-1-heikki.krogerus@linux.intel.com> <20180314131215.70833-2-heikki.krogerus@linux.intel.com> <20180320092004.GA21081@kroah.com> <20180320100412.GI11689@kuha.fi.intel.com> <20180320103259.GJ11689@kuha.fi.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Greg Kroah-Hartman , Darren Hart , Andy Shevchenko , MyungJoo Ham , Chanwoo Choi , Mathias Nyman , Guenter Roeck , Jun Li , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Tue, Mar 20, 2018 at 01:21:57PM +0100, Hans de Goede wrote: > On 20-03-18 11:32, Heikki Krogerus wrote: > > On Tue, Mar 20, 2018 at 12:04:12PM +0200, Heikki Krogerus wrote: > > > > > +void device_connection_remove(struct device_connection *con) > > > > > +{ > > > > > + mutex_lock(&devcon_lock); > > > > > + list_del_rcu(&con->list); > > > > > > > > See, rcu? > > > > > > True. I'll send one more version. > > > > Before I do that, Hans, can you quickly check this and see that I > > have not made any more mistakes? I don't trust myself anymore with > > these. > > This looks good to me (note I did not test only reviewed). Thanks. I'll send v9. Br, -- heikki