From: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
To: Platform Driver
<platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Cc: bberg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Christian Kellner
<ckellner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Andy Shevchenko
<andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Golden_Miller83-g/b1ySJe57IkP3XJZ0H8fw@public.gmane.org,
Henrique de Moraes Holschuh
<hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>,
FP1 Zhang <zhangfp1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org>,
Darren Hart <dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
Subject: [UNTESTED 1/3] thinkpad-acpi: silence HKEY 0x6032, 0x60f0, 0x6030
Date: Fri, 20 Apr 2018 12:16:27 -0300 [thread overview]
Message-ID: <20180420151629.12993-1-hmh@hmh.eng.br> (raw)
In-Reply-To: <-B_kuLAsoL7HNLV_as9l197VeKXFOu7R-GfEj_oV2TRu40VHMh4SRkEpgaOEMhEqi5-t9Qdk4c8_vMNOXDk_QHuNj-EPKs2afxrL0zTBZxc=@protonmail.ch>
Demote to debug level one existing thermal-control related event, and
also add two new ones that would otherwise trigger unknown event
warnings. These events are Windows-only for now.
We do report them to userspace in case they become useful in the future.
Signed-off-by: Henrique de Moraes Holschuh <hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
Reported-by: Jordan Glover <Golden_Miller83-g/b1ySJe57IkP3XJZ0H8fw@public.gmane.org>
---
Documentation/laptops/thinkpad-acpi.txt | 2 ++
drivers/platform/x86/thinkpad_acpi.c | 19 +++++++++++++++++--
2 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/Documentation/laptops/thinkpad-acpi.txt b/Documentation/laptops/thinkpad-acpi.txt
index 00b6dfed573c..6cced88de6da 100644
--- a/Documentation/laptops/thinkpad-acpi.txt
+++ b/Documentation/laptops/thinkpad-acpi.txt
@@ -540,8 +540,10 @@ Events that are propagated by the driver to userspace:
0x6021 ALARM: a sensor is too hot
0x6022 ALARM: a sensor is extremely hot
0x6030 System thermal table changed
+0x6032 Thermal Control command set completion (DYTC, Windows)
0x6040 Nvidia Optimus/AC adapter related (TO BE VERIFIED)
0x60C0 X1 Yoga 2016, Tablet mode status changed
+0x60F0 Thermal Transformation changed (GMTS, Windows)
Battery nearly empty alarms are a last resort attempt to get the
operating system to hibernate or shutdown cleanly (0x2313), or shutdown
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c
index da1ca4856ea1..cf25f0121d3b 100644
--- a/drivers/platform/x86/thinkpad_acpi.c
+++ b/drivers/platform/x86/thinkpad_acpi.c
@@ -212,7 +212,12 @@ enum tpacpi_hkey_event_t {
TP_HKEY_EV_ALARM_BAT_XHOT = 0x6012, /* battery critically hot */
TP_HKEY_EV_ALARM_SENSOR_HOT = 0x6021, /* sensor too hot */
TP_HKEY_EV_ALARM_SENSOR_XHOT = 0x6022, /* sensor critically hot */
- TP_HKEY_EV_THM_TABLE_CHANGED = 0x6030, /* thermal table changed */
+ TP_HKEY_EV_THM_TABLE_CHANGED = 0x6030, /* windows; thermal table changed */
+ TP_HKEY_EV_THM_CSM_COMPLETED = 0x6032, /* windows; thermal control set
+ * command completed. Related to
+ * AML DYTC */
+ TP_HKEY_EV_THM_TRANSFM_CHANGED = 0x60F0, /* windows; thermal transformation
+ * changed. Related to AML GMTS */
/* AC-related events */
TP_HKEY_EV_AC_CHANGED = 0x6040, /* AC status changed */
@@ -4042,7 +4047,17 @@ static bool hotkey_notify_6xxx(const u32 hkey,
switch (hkey) {
case TP_HKEY_EV_THM_TABLE_CHANGED:
- pr_info("EC reports that Thermal Table has changed\n");
+ pr_debug("EC reports: Thermal Table has changed\n");
+ /* recommended action: do nothing, we don't have
+ * Lenovo ATM information */
+ return true;
+ case TP_HKEY_EV_THM_CSM_COMPLETED:
+ pr_debug("EC reports: Thermal Control Command set completed (DYTC)\n");
+ /* recommended action: do nothing, we don't have
+ * Lenovo ATM information */
+ return true;
+ case TP_HKEY_EV_THM_TRANSFM_CHANGED:
+ pr_debug("EC reports: Thermal Transformation changed (GMTS)\n");
/* recommended action: do nothing, we don't have
* Lenovo ATM information */
return true;
--
2.11.0
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
next prev parent reply other threads:[~2018-04-20 15:16 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <PqonyRG1_zESPTDspqzZ2qO65lHbv5E1z8Ekcgrzh0TtbBmlm69BnfUqZIEuSbF-d1z0VeXHPMRRCQenBEMNP2L8NyTqvIui1FwdHnJ6RAc=@protonmail.ch>
[not found] ` <ei0r_oTyOQrFrZKDqLMWzJHdipDsPEu8zxZxhnNuNa6L7TMRdZzu43Ldx0mcuOiRI2Ud-Lx746lfMG-9YpGR7vcp1HrsuroruKEWzhrr3dg=@protonmail.ch>
[not found] ` <FA1DB435B97D5A4192BAE54A4EA542A99ABEF68F@CNMAILEX04.lenovo.com>
2018-02-15 14:42 ` ThinkPad Yoga 370 thinkpad_acpi unhandled events Andy Shevchenko
2018-02-15 18:21 ` Henrique de Moraes Holschuh
2018-02-17 13:47 ` Peter FP1 Zhang
2018-02-17 17:20 ` Jordan Glover
[not found] ` <FA1DB435B97D5A4192BAE54A4EA542A99ABF1461-bOPtaeQOlBPKZl9SKDgXa6BKnGwkPULj@public.gmane.org>
2018-04-03 12:04 ` Jordan Glover via ibm-acpi-devel
2018-04-03 16:30 ` Peter FP1 Zhang
[not found] ` <FA1DB435B97D5A4192BAE54A4EA542A99AC542CC-bOPtaeQOlBPKZl9SKDgXa6BKnGwkPULj@public.gmane.org>
2018-04-03 18:02 ` Henrique de Moraes Holschuh
[not found] ` <20180403180210.v5tnefl2cvdvudfi-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-04-03 18:25 ` Jordan Glover via ibm-acpi-devel
2018-04-09 2:58 ` Henrique de Moraes Holschuh
[not found] ` <20180409025836.ft3atn4goi4ebc4g-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-04-20 12:20 ` Jordan Glover via ibm-acpi-devel
2018-04-20 15:16 ` Henrique de Moraes Holschuh [this message]
[not found] ` <20180420151629.12993-1-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2018-04-20 15:16 ` [UNTESTED 2/3] thinkpad-acpi: do not report thermal sensor state for tablet mode switch Henrique de Moraes Holschuh
2018-04-20 15:16 ` [UNTESTED 3/3] thinkpad-acpi: silence false-positive-prone pr_warn Henrique de Moraes Holschuh
2018-04-20 15:17 ` ThinkPad Yoga 370 thinkpad_acpi unhandled events Henrique de Moraes Holschuh
[not found] ` <20180420151750.bp4wy3fm6ymniool-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-04-24 10:16 ` Jordan Glover via ibm-acpi-devel
2018-04-24 11:28 ` Henrique de Moraes Holschuh
[not found] ` <20180424112801.63ojsumt34q26wor-ZGHd14iZgfaRjzvQDGKj+xxZW9W5cXbT@public.gmane.org>
2018-04-24 16:12 ` Andy Shevchenko
[not found] ` <CAHp75VciLyh1Y1sws69Hn=vN39suV+HH-JwNLcbeUnZ_dwrc0Q-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-04-24 19:56 ` [PATCH 1/3] thinkpad-acpi: silence HKEY 0x6032, 0x60f0, 0x6030 Henrique de Moraes Holschuh
2018-04-24 19:56 ` [PATCH 2/3] thinkpad-acpi: do not report thermal sensor state for tablet mode switch Henrique de Moraes Holschuh
2018-04-24 19:56 ` [PATCH 3/3] thinkpad-acpi: silence false-positive-prone pr_warn Henrique de Moraes Holschuh
[not found] ` <20180424195605.17526-3-hmh-N3TV7GIv+o9fyO9Q7EP/yw@public.gmane.org>
2018-04-25 14:16 ` Andy Shevchenko
2018-04-25 11:13 ` ThinkPad Yoga 370 thinkpad_acpi unhandled events Jordan Glover via ibm-acpi-devel
2018-04-25 11:25 ` Jordan Glover via ibm-acpi-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420151629.12993-1-hmh@hmh.eng.br \
--to=hmh-n3tv7giv+o9fyo9q7ep/yw@public.gmane.org \
--cc=Golden_Miller83-g/b1ySJe57IkP3XJZ0H8fw@public.gmane.org \
--cc=andy.shevchenko-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=bberg-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=ckellner-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=dvhart-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org \
--cc=ibm-acpi-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=platform-driver-x86-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=zhangfp1-6jq1YtArVR3QT0dZR+AlfA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).