From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Andy Gross <andy.gross@linaro.org>,
David Brown <david.brown@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Hans de Goede <hdegoede@redhat.com>,
Michal Hocko <mhocko@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Rik van Riel <riel@surriel.com>,
Laura Abbott <labbott@redhat.com>,
Vlastimil Babka <vbabka@suse.cz>
Cc: dmitry.torokhov@gmail.com,
"Matt Fleming" <matt@codeblueprint.co.uk>,
"Will Deacon" <will.deacon@arm.com>,
platform-driver-x86@vger.kernel.org,
"David Howells" <dhowells@redhat.com>,
"Peter Jones" <pjones@redhat.com>,
mcgrof@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
nbroeking@me.com, "Jonathan Corbet" <corbet@lwn.net>,
x86@kernel.org, "Arve Hjønnevåg" <arve@android.com>,
"Ingo Molnar" <mingo@redhat.com>,
"Darren Hart" <dvhart@infradead.org>,
"Mimi Zohar" <zohar@linux.vnet.ibm.com>,
"Arend Van Spriel" <arend.vanspriel@broadcom.com>,
"Todd Kjos" <tkjos@android.com>,
"Kees Cook" <keescook@chromium.org>,
linux-efi <linux-efi@vger.kernel.org>,
linux-arm-msm@vger.kernel.org, "Torsten Duwe" <duwe@suse.de>,
"Josh Triplett" <josh@joshtriplett.org>,
"Chris Wright" <chrisw@sous-sol.org>,
"Andy Lutomirski" <luto@kernel.org>
Subject: Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()?
Date: Wed, 6 Jun 2018 22:32:57 +0200 [thread overview]
Message-ID: <20180606203257.GH4511@wotan.suse.de> (raw)
In-Reply-To: <20180601192346.GQ4511@wotan.suse.de>
On Fri, Jun 01, 2018 at 09:23:46PM +0200, Luis R. Rodriguez wrote:
> On Tue, May 08, 2018 at 03:38:05PM +0000, Luis R. Rodriguez wrote:
> > On Fri, May 04, 2018 at 12:44:37PM -0700, Martijn Coenen wrote:
> > >
> > > I think the Qualcomm folks owning this (Andy, David, Bjorn, already
> > > cc'd here) are better suited to answer that question.
> >
> > Andy, David, Bjorn?
>
> Andy, David, Bjorn?
A month now with no answer...
Perhaps someone who has this hardware can find out empirically for us, as
follows (mm folks is this right?):
page = virt_to_page(address);
if (!page)
fail closed...
if (page_zone(page) == ZONE_DMA || page_zone(page) == ZONE_DMA32)
this is a DMA buffer
else
not DMA!
Note that when request_firmware_into_buf() was being reviewed Mimi had asked back
in 2016 [0] that if a DMA buffer was going to be used READING_FIRMWARE_DMA should be
used otherwise READING_FIRMWARE_PREALLOC_BUFFER was fine.
If it is a DMA buffer *now*, why / how did this change?
[0] https://patchwork.kernel.org/patch/9074611/
Luis
next prev parent reply other threads:[~2018-06-06 20:32 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-08 17:40 [PATCH v3 0/5] efi/firmware/platform-x86: Add EFI embedded fw support Hans de Goede
2018-04-08 17:40 ` [PATCH v3 1/5] efi: Export boot-services code and data as debugfs-blobs Hans de Goede
2018-04-16 8:23 ` Ard Biesheuvel
2018-04-24 13:11 ` Hans de Goede
2018-04-23 11:55 ` Greg Kroah-Hartman
2018-04-08 17:40 ` [PATCH v3 2/5] efi: Add embedded peripheral firmware support Hans de Goede
2018-04-16 8:28 ` Ard Biesheuvel
2018-04-24 13:17 ` Hans de Goede
2018-04-17 0:17 ` Luis R. Rodriguez
2018-04-17 8:58 ` Hans de Goede
2018-04-17 9:19 ` Hans de Goede
2018-04-23 21:11 ` Luis R. Rodriguez
2018-04-24 15:09 ` Hans de Goede
2018-04-24 16:07 ` Mimi Zohar
2018-04-24 18:33 ` Hans de Goede
2018-04-24 23:42 ` Luis R. Rodriguez
2018-04-25 5:00 ` Mimi Zohar
2018-04-25 17:55 ` Luis R. Rodriguez
2018-05-04 0:21 ` Luis R. Rodriguez
2018-05-04 15:26 ` Martijn Coenen
2018-05-04 19:44 ` Martijn Coenen
2018-05-08 15:38 ` Luis R. Rodriguez
2018-05-08 16:10 ` Luis R. Rodriguez
2018-06-07 16:49 ` Bjorn Andersson
2018-06-07 18:22 ` Luis R. Rodriguez
2018-06-01 19:23 ` Luis R. Rodriguez
2018-06-06 20:32 ` Luis R. Rodriguez [this message]
2018-06-06 20:41 ` Do Qualcomm drivers use DMA buffers for request_firmware_into_buf()? Ard Biesheuvel
2018-06-06 22:29 ` Luis R. Rodriguez
2018-06-06 22:41 ` Ard Biesheuvel
2018-06-06 22:55 ` Luis R. Rodriguez
2018-06-07 16:18 ` Bjorn Andersson
2018-06-07 16:23 ` Ard Biesheuvel
2018-06-07 16:33 ` Greg Kroah-Hartman
2018-06-07 16:43 ` Ard Biesheuvel
2018-06-07 16:49 ` Greg Kroah-Hartman
2018-06-07 16:56 ` Ard Biesheuvel
2018-06-07 18:21 ` Bjorn Andersson
2018-06-07 18:42 ` Ard Biesheuvel
2018-06-26 0:08 ` Bjorn Andersson
2018-06-27 18:00 ` Luis R. Rodriguez
2018-06-27 22:21 ` Ard Biesheuvel
2018-06-27 23:33 ` Luis R. Rodriguez
2018-06-27 23:42 ` Ard Biesheuvel
2018-06-27 23:50 ` Luis R. Rodriguez
2018-06-08 6:41 ` Vlastimil Babka
2018-06-07 18:06 ` Bjorn Andersson
2018-06-18 23:49 ` Luis R. Rodriguez
2018-06-07 16:33 ` [PATCH v3 2/5] efi: Add embedded peripheral firmware support Bjorn Andersson
2018-04-08 17:40 ` [PATCH v3 3/5] platform/x86: Rename silead_dmi to touchscreen_dmi Hans de Goede
2018-04-09 8:07 ` Andy Shevchenko
2018-04-20 0:20 ` Darren Hart
2018-04-08 17:40 ` [PATCH v3 4/5] platform/x86: touchscreen_dmi: Add EFI embedded firmware info support Hans de Goede
2018-04-08 17:40 ` [PATCH v3 5/5] platform/x86: touchscreen_dmi: Add info for the Chuwi Vi8 Plus tablet Hans de Goede
2018-04-09 8:10 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180606203257.GH4511@wotan.suse.de \
--to=mcgrof@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=andy.gross@linaro.org \
--cc=arend.vanspriel@broadcom.com \
--cc=arve@android.com \
--cc=bjorn.andersson@linaro.org \
--cc=chrisw@sous-sol.org \
--cc=corbet@lwn.net \
--cc=david.brown@linaro.org \
--cc=devel@driverdev.osuosl.org \
--cc=dhowells@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=duwe@suse.de \
--cc=dvhart@infradead.org \
--cc=hdegoede@redhat.com \
--cc=hpa@zytor.com \
--cc=josh@joshtriplett.org \
--cc=keescook@chromium.org \
--cc=labbott@redhat.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=luto@kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=mhocko@kernel.org \
--cc=mingo@redhat.com \
--cc=nbroeking@me.com \
--cc=pjones@redhat.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=riel@surriel.com \
--cc=tkjos@android.com \
--cc=vbabka@suse.cz \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
--cc=zohar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).