From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v13 02/13] x86/cpufeature: Add SGX and SGX_LC CPU features Date: Tue, 28 Aug 2018 10:17:23 +0300 Message-ID: <20180828071723.GA15508@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-3-jarkko.sakkinen@linux.intel.com> <105F7BF4D0229846AF094488D65A09893540B623@PGSMSX112.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <105F7BF4D0229846AF094488D65A09893540B623@PGSMSX112.gar.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "Huang, Kai" Cc: "x86@kernel.org" , "platform-driver-x86@vger.kernel.org" , "Hansen, Dave" , "Christopherson, Sean J" , "nhorman@redhat.com" , "npmccallum@redhat.com" , "linux-sgx@vger.kernel.org" , Kai Huang , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Borislav Petkov , Konrad Rzeszutek Wilk , David Woodhouse , "open list:X86 ARCHITECTURE (32-BIT AND 64-BIT)" List-Id: platform-driver-x86.vger.kernel.org On Tue, Aug 28, 2018 at 12:07:41AM +0000, Huang, Kai wrote: > > +#define X86_FEATURE_SGX_LC (16*32+30) /* supports SGX launch > > configuration */ > > Sorry if it was me who wrote the comment "SGX launch configuration". I > think we should just use "SGX launch control". :) Not sure if we should change though. The former is more self-explaining, the latter is "more official". /Jarkko