From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v13 10/13] x86/sgx: Add sgx_einit() for initializing enclaves Date: Tue, 4 Sep 2018 18:26:05 +0300 Message-ID: <20180904152605.GA8344@linux.intel.com> References: <20180827185507.17087-1-jarkko.sakkinen@linux.intel.com> <20180827185507.17087-11-jarkko.sakkinen@linux.intel.com> <1535406078.3416.9.camel@intel.com> <20180828070129.GA5301@linux.intel.com> <105F7BF4D0229846AF094488D65A09893541037C@PGSMSX112.gar.corp.intel.com> <20180831121645.GA18075@linux.intel.com> <20180831181509.GB21555@linux.intel.com> <20180903191926.GC13497@linux.intel.com> <105F7BF4D0229846AF094488D65A09893541970F@PGSMSX112.gar.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <105F7BF4D0229846AF094488D65A09893541970F@PGSMSX112.gar.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org To: "Huang, Kai" Cc: "Christopherson, Sean J" , "platform-driver-x86@vger.kernel.org" , "x86@kernel.org" , "nhorman@redhat.com" , "linux-kernel@vger.kernel.org" , "tglx@linutronix.de" , "suresh.b.siddha@intel.com" , "Ayoun, Serge" , "hpa@zytor.com" , "npmccallum@redhat.com" , "mingo@redhat.com" , "linux-sgx@vger.kernel.org" , "Hansen, Dave" List-Id: platform-driver-x86.vger.kernel.org On Mon, Sep 03, 2018 at 11:45:14PM +0000, Huang, Kai wrote: > But INVALID_TOKEN is not only returned when MSRs are mismatched, so do > you plan to check to rule out other cases that cause INVALID_TOKEN > before retrying EINIT, or unconditionally retry EINIT? And we should > only retry once? In the case of this error we will do wrmsrs and retry einit once. This is how I understood it at least. Q: Do we have to care about VMM sleep anyway? I mean if VMM always traps EINIT it can write the MSRs with guest values if it has been sleeping. If the answer is no, then retrying once should be a complete solution and we don't need pm_cnt. /Jarkko