From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v15 23/23] x86/sgx: Driver documentation Date: Thu, 8 Nov 2018 16:39:42 +0200 Message-ID: <20181108143942.GA13792@linux.intel.com> References: <20181102231320.29164-1-jarkko.sakkinen@linux.intel.com> <20181102231320.29164-24-jarkko.sakkinen@linux.intel.com> <154ded23-fd1d-f324-4e0a-9de8eddcda6d@intel.com> <20181106054911.GA15575@linux.intel.com> <20181107163019.GA11509@linux.intel.com> <914dd171-b48a-12d9-eb77-3c40c8b210cb@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <914dd171-b48a-12d9-eb77-3c40c8b210cb@intel.com> Sender: linux-kernel-owner@vger.kernel.org To: Dave Hansen Cc: x86@kernel.org, platform-driver-x86@vger.kernel.org, linux-sgx@vger.kernel.org, sean.j.christopherson@intel.com, nhorman@redhat.com, npmccallum@redhat.com, serge.ayoun@intel.com, shay.katz-zamir@intel.com, haitao.huang@intel.com, mark.shanahan@intel.com, andriy.shevchenko@linux.intel.com, Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "open list:DOCUMENTATION" , open list List-Id: platform-driver-x86.vger.kernel.org On Wed, Nov 07, 2018 at 09:09:37AM -0800, Dave Hansen wrote: > On 11/7/18 8:30 AM, Jarkko Sakkinen wrote: > >> Does this code run when I type "make kselftest"? If not, I think we > >> should rectify that. > > No, it doesn't. It is just my backup for the non-SDK user space code > > that I've made that I will use to fork my user space SGX projects in > > the future. > > > > I can work-out a selftest (and provide a new patch in the series) but > > I'm still wondering what the enclave should do. I would suggest that > > we start with an enclave that does just EEXIT and nothing else. > > Yeah, that's a start. But, a good selftest would include things like > faults and error conditions. Great. We can add more entry points to the enclave for different tests but I'll start with a bare minimum. And yeah but ever goes into next version I'll document the fault handling. /Jarkko