From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Sakkinen Subject: Re: [PATCH v17 18/23] platform/x86: Intel SGX driver Date: Mon, 19 Nov 2018 19:19:34 +0200 Message-ID: <20181119171934.GA16252@linux.intel.com> References: <20181116010412.23967-1-jarkko.sakkinen@linux.intel.com> <20181116010412.23967-19-jarkko.sakkinen@linux.intel.com> <20181119150655.GA11843@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Jethro Beekman Cc: "x86@kernel.org" , "platform-driver-x86@vger.kernel.org" , "linux-sgx@vger.kernel.org" , "dave.hansen@intel.com" , "sean.j.christopherson@intel.com" , "nhorman@redhat.com" , "npmccallum@redhat.com" , "serge.ayoun@intel.com" , "shay.katz-zamir@intel.com" , "haitao.huang@linux.intel.com" , "andriy.shevchenko@linux.intel.com" , "tglx@linutronix.de" , "kai.svahn@intel.com" , "mark.shanahan@intel.com" , lut List-Id: platform-driver-x86.vger.kernel.org On Mon, Nov 19, 2018 at 04:22:54PM +0000, Jethro Beekman wrote: > On 2018-11-19 20:36, Jarkko Sakkinen wrote: > > Question: should be dissolve the driver completely and move this code to > > arch/x86/kernel/cpu/sgx/ (and rename intel_sgx.c as main.c)? Swapping > > patch removes the possibility to compile this as a module anyway. > > No. We should keep the capability to build this as a module for other users > of SGX. What is the swapping patch and why doesn't allow building as a > module? In some earlier version of the patch set the request was to remove the callback interface to the driver so now core does direct calls to the swapping operations. /Jarkko