From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heikki Krogerus Subject: Re: [PATCH v2 09/12] platform/x86: intel_cht_int33fe: Provide software nodes for the devices Date: Thu, 11 Apr 2019 16:35:46 +0300 Message-ID: <20190411133546.GA25743@kuha.fi.intel.com> References: <20190410152505.87041-1-heikki.krogerus@linux.intel.com> <20190410152505.87041-10-heikki.krogerus@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Andy Shevchenko Cc: "Rafael J. Wysocki" , Greg Kroah-Hartman , Hans de Goede , Darren Hart , Andy Shevchenko , ACPI Devel Maling List , Linux Kernel Mailing List , Platform Driver List-Id: platform-driver-x86.vger.kernel.org On Thu, Apr 11, 2019 at 04:31:51PM +0300, Andy Shevchenko wrote: > On Wed, Apr 10, 2019 at 6:25 PM Heikki Krogerus > wrote: > > > > Software nodes provide two features that we will need later. > > 1) Software nodes can have references to other software nodes. > > 2) Software nodes can exist before a device entry is created. > > > > It seems does two things in one patch, and the first one is not > mentioned in the commit message. > I would suggest to create a preparation patch which extracts finding > and registering max17047 device followed by what you do here. OK, I'll split the patch. thanks, -- heikki