From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v5 10/14] software node: rename is_array to is_inline Date: Mon, 14 Oct 2019 10:37:20 +0300 Message-ID: <20191014073720.GH32742@smile.fi.intel.com> References: <20191011230721.206646-1-dmitry.torokhov@gmail.com> <20191011230721.206646-11-dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20191011230721.206646-11-dmitry.torokhov@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Dmitry Torokhov Cc: "Rafael J. Wysocki" , Heikki Krogerus , Mika Westerberg , Linus Walleij , Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org List-Id: platform-driver-x86.vger.kernel.org On Fri, Oct 11, 2019 at 04:07:17PM -0700, Dmitry Torokhov wrote: > We do not need a special flag to know if we are dealing with an array, > as we can get that data from ratio between element length and the data > size, however we do need a flag to know whether the data is stored > directly inside property_entry or separately. > - if (prop->is_array) > + if (!prop->is_inline) > - if (p->is_array) { > + if (!p->is_inline) { > - if (src->is_array) { > + if (!src->is_inline) { May we have positive conditionals instead? > + * @is_inline: True when the property value is stored directly in I think word 'directly' is superfluous here. Or, perhaps, 'stored directly' -> 'embedded' > + * &struct property_entry instance. > + * @pointer: Pointer to the property when it is stored separately from > + * the &struct property_entry instance. 'separately from' -> 'outside' ? > + * @value: Value of the property when it is stored inline. 'stored inline' -> 'embedded in the &struct...' ? -- With Best Regards, Andy Shevchenko