From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v8 1/6] software node: rename is_array to is_inline Date: Thu, 12 Dec 2019 13:28:25 +0200 Message-ID: <20191212112825.GK32742@smile.fi.intel.com> References: <20191108042225.45391-1-dmitry.torokhov@gmail.com> <20191108042225.45391-2-dmitry.torokhov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Marek Szyprowski Cc: Dmitry Torokhov , "Rafael J. Wysocki" , Heikki Krogerus , Mika Westerberg , Linus Walleij , Ard Biesheuvel , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, 'Linux Samsung SOC' , Krzysztof Kozlowski , Felipe Balbi , Linux USB Mailing List List-Id: platform-driver-x86.vger.kernel.org On Thu, Dec 12, 2019 at 12:12:36PM +0100, Marek Szyprowski wrote: > Dear All, > > On 08.11.2019 05:22, Dmitry Torokhov wrote: > > We do not need a special flag to know if we are dealing with an array, > > as we can get that data from ratio between element length and the data > > size, however we do need a flag to know whether the data is stored > > directly inside property_entry or separately. > > > > Signed-off-by: Dmitry Torokhov > > Today I've noticed that this patch got merged to linux-next as commit > e6bff4665c595b5a4aff173848851ed49ac3bfad. Sadly it breaks DWC3/xHCI > driver operation on Samsung Exynos5 SoCs (and probably on other SoCs > which use DWC3 in host mode too). I get the following errors during boot: > > dwc3 12000000.dwc3: failed to add properties to xHCI > dwc3 12000000.dwc3: failed to initialize host > dwc3: probe of 12000000.dwc3 failed with error -61 > > Here is a full kernel log from Exynos5250-based Snow Chromebook on KernelCI: > > https://storage.kernelci.org/next/master/next-20191212/arm/exynos_defconfig/gcc-8/lab-collabora/boot-exynos5250-snow.txt > > (lack of 'ref' clk is not related nor fatal to the driver operation). > > The code which fails after this patch is located in > drivers/usb/dwc3/host.c. Let me know if I can help more in locating the bug. Thank you for report. I think we should not have that patch in the fist place... I used to have a bad feeling about it and then forgot about it existence. -- With Best Regards, Andy Shevchenko