From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Michael S. Tsirkin" Subject: Re: [PATCH v2 18/24] mlxbf-tmfifo: sparse tags for config access Date: Wed, 5 Aug 2020 09:29:12 -0400 Message-ID: <20200805092904-mutt-send-email-mst@kernel.org> References: <20200803205814.540410-1-mst@redhat.com> <20200803205814.540410-19-mst@redhat.com> <20200804165634.4df11c6b.cohuck@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200804165634.4df11c6b.cohuck@redhat.com> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" To: Cornelia Huck Cc: Vadim Pasternak , linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Darren Hart , virtualization@lists.linux-foundation.org, Andy Shevchenko List-Id: platform-driver-x86.vger.kernel.org On Tue, Aug 04, 2020 at 04:56:34PM +0200, Cornelia Huck wrote: > On Mon, 3 Aug 2020 17:00:01 -0400 > "Michael S. Tsirkin" wrote: > > > mlxbf-tmfifo accesses config space using native types - > > which works for it since the legacy virtio native types. > > > > This will break if it ever needs to support modern virtio, > > so with new tags previously introduced for virtio net config, > > sparse now warns for this in drivers. > > > > Since this is a legacy only device, fix it up using > > virtio_legacy_is_little_endian for now. > > I'm wondering if the driver should make this more explicit? Not sure how though. > No issues with the patch, though. > > > > > No functional changes. > > > > Signed-off-by: Michael S. Tsirkin > > --- > > drivers/platform/mellanox/mlxbf-tmfifo.c | 13 ++++++++++--- > > 1 file changed, 10 insertions(+), 3 deletions(-) > > Acked-by: Cornelia Huck