X86 platform drivers
 help / color / mirror / Atom feed
From: Vadim Pasternak <vadimp@nvidia.com>
To: andy.shevchenko@gmail.com, dvhart@infradead.org
Cc: platform-driver-x86@vger.kernel.org, Vadim Pasternak <vadimp@nvidia.com>
Subject: [PATCH platform-next 2/5] platform/x86: mlx-platform: Fix extended topology configuration for power supply units
Date: Wed, 23 Sep 2020 20:20:50 +0300	[thread overview]
Message-ID: <20200923172053.26296-3-vadimp@nvidia.com> (raw)
In-Reply-To: <20200923172053.26296-1-vadimp@nvidia.com>

Fix topology configuration for power supply units in structure
'mlxplat_mlxcpld_ext_pwr_items_data', due to hardware change.

Note: no need to backport the fix, since there is no such hardware yet
(equipped with four power) at the filed.

Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
---
 drivers/platform/x86/mlx-platform.c | 18 +++++++++++++-----
 1 file changed, 13 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/mlx-platform.c b/drivers/platform/x86/mlx-platform.c
index e57d2471dfcb..04a745095c37 100644
--- a/drivers/platform/x86/mlx-platform.c
+++ b/drivers/platform/x86/mlx-platform.c
@@ -171,7 +171,6 @@
 #define MLXPLAT_CPLD_NR_NONE			-1
 #define MLXPLAT_CPLD_PSU_DEFAULT_NR		10
 #define MLXPLAT_CPLD_PSU_MSNXXXX_NR		4
-#define MLXPLAT_CPLD_PSU_MSNXXXX_NR2		3
 #define MLXPLAT_CPLD_FAN1_DEFAULT_NR		11
 #define MLXPLAT_CPLD_FAN2_DEFAULT_NR		12
 #define MLXPLAT_CPLD_FAN3_DEFAULT_NR		13
@@ -338,6 +337,15 @@ static struct i2c_board_info mlxplat_mlxcpld_pwr[] = {
 	},
 };
 
+static struct i2c_board_info mlxplat_mlxcpld_ext_pwr[] = {
+	{
+		I2C_BOARD_INFO("dps460", 0x5b),
+	},
+	{
+		I2C_BOARD_INFO("dps460", 0x5a),
+	},
+};
+
 static struct i2c_board_info mlxplat_mlxcpld_fan[] = {
 	{
 		I2C_BOARD_INFO("24c32", 0x50),
@@ -910,15 +918,15 @@ static struct mlxreg_core_data mlxplat_mlxcpld_ext_pwr_items_data[] = {
 		.label = "pwr3",
 		.reg = MLXPLAT_CPLD_LPC_REG_PWR_OFFSET,
 		.mask = BIT(2),
-		.hpdev.brdinfo = &mlxplat_mlxcpld_pwr[0],
-		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR2,
+		.hpdev.brdinfo = &mlxplat_mlxcpld_ext_pwr[0],
+		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR,
 	},
 	{
 		.label = "pwr4",
 		.reg = MLXPLAT_CPLD_LPC_REG_PWR_OFFSET,
 		.mask = BIT(3),
-		.hpdev.brdinfo = &mlxplat_mlxcpld_pwr[1],
-		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR2,
+		.hpdev.brdinfo = &mlxplat_mlxcpld_ext_pwr[1],
+		.hpdev.nr = MLXPLAT_CPLD_PSU_MSNXXXX_NR,
 	},
 };
 
-- 
2.11.0


  parent reply	other threads:[~2020-09-23 17:27 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-23 17:20 [PATCH platform-next 0/5] platform/x86: mlx-platform: Topology fixes and configuration updates Vadim Pasternak
2020-09-23 17:20 ` [PATCH platform-next 1/5] platform/x86: mlx-platform: Remove PSU EEPROM configuration Vadim Pasternak
2020-09-24  8:33   ` Hans de Goede
2020-09-23 17:20 ` Vadim Pasternak [this message]
2020-09-24  8:33   ` [PATCH platform-next 2/5] platform/x86: mlx-platform: Fix extended topology configuration for power supply units Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 3/5] platform_data/mlxreg: Update module license Vadim Pasternak
2020-09-24  8:33   ` Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 4/5] platform_data/mlxreg: Extend core platform structure Vadim Pasternak
2020-09-24  8:36   ` Hans de Goede
2020-09-23 17:20 ` [PATCH platform-next 5/5] platform/x86: mlx-platform: Add capability field to platform FAN description Vadim Pasternak
2020-09-24  8:36   ` Hans de Goede
2020-10-07 21:24 ` [PATCH platform-next 0/5] platform/x86: mlx-platform: Topology fixes and configuration updates Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200923172053.26296-3-vadimp@nvidia.com \
    --to=vadimp@nvidia.com \
    --cc=andy.shevchenko@gmail.com \
    --cc=dvhart@infradead.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox