From: Kees Cook <keescook@chromium.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Mark Gross <mgross@linux.intel.com>,
Andy Shevchenko <andy@infradead.org>,
Dell.Client.Kernel@dell.com, platform-driver-x86@vger.kernel.org
Subject: Re: [PATCH] platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call
Date: Thu, 26 Aug 2021 20:19:47 -0700 [thread overview]
Message-ID: <202108262019.F3C9681F91@keescook> (raw)
In-Reply-To: <20210826140822.71198-1-hdegoede@redhat.com>
On Thu, Aug 26, 2021 at 04:08:22PM +0200, Hans de Goede wrote:
> As pointed out be Kees Cook if we return -EIO because the
> obj->type != ACPI_TYPE_BUFFER, then we must kfree the
> output buffer before the return.
>
> Fixes: 1a258e670434 ("platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver")
> Reported-by: Kees Cook <keescook@chromium.org>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Excellent! Thanks for doing this. :)
-Kees
--
Kees Cook
prev parent reply other threads:[~2021-08-27 3:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 14:08 [PATCH] platform/x86: dell-smbios-wmi: Add missing kfree in error-exit from run_smbios_call Hans de Goede
2021-08-27 3:19 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202108262019.F3C9681F91@keescook \
--to=keescook@chromium.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=andy@infradead.org \
--cc=hdegoede@redhat.com \
--cc=mgross@linux.intel.com \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox