X86 platform drivers
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: platform-driver-x86@vger.kernel.org, hdegoede@redhat.com,
	santoshkumar.yadav@barco.com
Cc: Peter Korsgaard <peter.korsgaard@barco.com>
Subject: [PATCH] platform/x86: barco-p50-gpio: use KEY_VENDOR for button insted of KEY_RESTART
Date: Fri, 22 Oct 2021 14:46:12 +0200	[thread overview]
Message-ID: <20211022124612.19780-1-peter@korsgaard.com> (raw)
In-Reply-To: <150f27d2-32b9-403b-01ff-8ab7d971d1d1@redhat.com>

From: Peter Korsgaard <peter.korsgaard@barco.com>

It turns out that systemd-logind by default listens for KEY_RESTART input
events and reboots the machine, which isn't great - So use KEY_VENDOR for
the vendor specific identify button instead to not conflict.

Signed-off-by: Peter Korsgaard <peter.korsgaard@barco.com>
---
 drivers/platform/x86/barco-p50-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/barco-p50-gpio.c
index ca0b2564c407..f5c72e33f9ae 100644
--- a/drivers/platform/x86/barco-p50-gpio.c
+++ b/drivers/platform/x86/barco-p50-gpio.c
@@ -101,7 +101,7 @@ static struct gpio_led_platform_data leds_pdata = {
 /* GPIO keyboard */
 static struct gpio_keys_button buttons[] = {
 	{
-		.code = KEY_RESTART,
+		.code = KEY_VENDOR,
 		.gpio = P50_GPIO_LINE_BTN,
 		.active_low = 1,
 		.type = EV_KEY,
-- 
2.20.1


  reply	other threads:[~2021-10-22 12:46 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-13 14:03 [PATCH] platform/x86: Support for EC-connected GPIOs for identify LED/button on Barco P50 board Santosh Kumar Yadav
2021-10-19 14:50 ` Hans de Goede
2021-10-19 15:14   ` Peter Korsgaard
2021-10-20 12:36 ` [PATCH v2] " Peter Korsgaard
2021-10-20 14:39   ` Hans de Goede
2021-10-22 12:46     ` Peter Korsgaard [this message]
2021-10-22 15:40       ` [PATCH] platform/x86: barco-p50-gpio: use KEY_VENDOR for button insted of KEY_RESTART Peter Korsgaard
2021-10-22 16:00         ` Hans de Goede
2021-10-24  8:19       ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211022124612.19780-1-peter@korsgaard.com \
    --to=peter@korsgaard.com \
    --cc=hdegoede@redhat.com \
    --cc=peter.korsgaard@barco.com \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=santoshkumar.yadav@barco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox