From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B808DC433EF for ; Thu, 3 Mar 2022 00:02:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229977AbiCCADI (ORCPT ); Wed, 2 Mar 2022 19:03:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58784 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229936AbiCCADH (ORCPT ); Wed, 2 Mar 2022 19:03:07 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DDC0010FC3; Wed, 2 Mar 2022 16:02:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1646265741; x=1677801741; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Y6ExcioFqlJjDZQpSBxXHW53xAZe9Os27BCVKLck3NM=; b=jPfE10oPlf9CFds7d6MCbvoSWyd/te2l7pfVFcH2jVgl0izWxAiGmThj 7rJZBRI8VoRs2mnbStWPoiwzvUcm2nL3sj76K13guOYxx4NrBnmpTwdCd NOx4/drpsc0Z8TvCoROIkAYamAVR9csOXPrYptNpYOPlZZKZzzJ6aAeW+ 44BlztYW/RTRKgPQ8vDAd0BLKnVNoKKFNb+cTleSChz8ahdBA1QRFxEi+ lT8OGuDyB50ocaB9tnp+GcUz4s+r/yyLxKIWw9Zzws6q20r3spVjpF3kP oBScnOSt266DYNIZFTmqlhZhazX59IRVcc9FOpbmd2Pkcp+9jApChSpsT w==; X-IronPort-AV: E=McAfee;i="6200,9189,10274"; a="278208534" X-IronPort-AV: E=Sophos;i="5.90,150,1643702400"; d="scan'208";a="278208534" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 15:39:16 -0800 X-IronPort-AV: E=Sophos;i="5.90,150,1643702400"; d="scan'208";a="641884850" Received: from otc-nc-03.jf.intel.com (HELO otc-nc-03) ([10.54.39.125]) by orsmga004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Mar 2022 15:39:16 -0800 Date: Wed, 2 Mar 2022 15:31:00 -0800 From: "Raj, Ashok" To: "Williams, Dan J" Cc: "hdegoede@redhat.com" , "markgross@kernel.org" , "Joseph, Jithu" , "corbet@lwn.net" , "Luck, Tony" , "dave.hansen@linux.intel.com" , "patches@lists.linux.dev" , "linux-kernel@vger.kernel.org" , "mingo@redhat.com" , "rostedt@goodmis.org" , "Shankar, Ravi V" , "tglx@linutronix.de" , "platform-driver-x86@vger.kernel.org" , "linux-doc@vger.kernel.org" , "hpa@zytor.com" , "bp@alien8.de" , "gregkh@linuxfoundation.org" , "andriy.shevchenko@linux.intel.com" , "x86@kernel.org" , Ashok Raj Subject: Re: [RFC 03/10] platform/x86/intel/ifs: Add driver for In-Field Scan Message-ID: <20220302233100.GE9351@otc-nc-03> References: <20220301195457.21152-1-jithu.joseph@intel.com> <20220301195457.21152-4-jithu.joseph@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: platform-driver-x86@vger.kernel.org On Wed, Mar 02, 2022 at 03:24:47PM -0800, Dan Williams wrote: > On Tue, 2022-03-01 at 11:54 -0800, Jithu Joseph wrote: > > In-Field Scan (IFS) provides hardware hooks to perform core tests and > > report failures for portions of silicon that lack error detection > > capabilities, which will be available in some server SKUs starting with > > Sapphire Rapids. It offers infrastructure to specific users such as cloud > > providers or OEMs to schedule tests and find in-field failures due to aging > > in silicon that might not necessarily be reported with normal machine > > checks. > > > > Add basic parts of the IFS module (initialization and check IFS capability > > support in a processor). > > > > MSR IA32_CORE_CAPABILITY is a feature-enumerating MSR, bit 2 of which > > reports MSR_INTEGRITY_CAPABILITIES. Processor that supports IFS > > should reports the MSR_INTEGRITY_CAPABILITIES enabled. > > > > Please check the latest Intel 64 and IA-32 Architectures Software > > Developer's Manual for more detailed information on the MSR and the > > MSR_INTEGRITY_CAPABILITIES. > > > > Originally-by: Kyung Min Park > > Signed-off-by: Jithu Joseph > > Reviewed-by: Ashok Raj > > Reviewed-by: Tony Luck > > --- > > MAINTAINERS | 7 ++++ > > drivers/platform/x86/intel/Kconfig | 1 + > > drivers/platform/x86/intel/Makefile | 1 + > > drivers/platform/x86/intel/ifs/Kconfig | 9 +++++ > > drivers/platform/x86/intel/ifs/Makefile | 7 ++++ > > drivers/platform/x86/intel/ifs/core.c | 49 +++++++++++++++++++++++++ > > drivers/platform/x86/intel/ifs/ifs.h | 14 +++++++ > > 7 files changed, 88 insertions(+) > > create mode 100644 drivers/platform/x86/intel/ifs/Kconfig > > create mode 100644 drivers/platform/x86/intel/ifs/Makefile > > create mode 100644 drivers/platform/x86/intel/ifs/core.c > > create mode 100644 drivers/platform/x86/intel/ifs/ifs.h > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 777cd6fa2b3d..4c9912c0d725 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -9685,6 +9685,13 @@ B: https://bugzilla.kernel.org > > T: git git://git.kernel.org/pub/scm/linux/kernel/git/lenb/linux.git > > F: drivers/idle/intel_idle.c > > > > +INTEL IN FIELD SCAN (IFS) DRIVER > > +M: Jithu Joseph > > +R: Ashok Raj > > +R: Tony Luck > > +S: Maintained > > +F: drivers/platform/x86/intel/ifs > > + > > INTEL INTEGRATED SENSOR HUB DRIVER > > M: Srinivas Pandruvada > > M: Jiri Kosina > > diff --git a/drivers/platform/x86/intel/Kconfig b/drivers/platform/x86/intel/Kconfig > > index 8e65086bb6c8..7339e7daf0a1 100644 > > --- a/drivers/platform/x86/intel/Kconfig > > +++ b/drivers/platform/x86/intel/Kconfig > > @@ -4,6 +4,7 @@ > > # > > > > source "drivers/platform/x86/intel/atomisp2/Kconfig" > > +source "drivers/platform/x86/intel/ifs/Kconfig" > > source "drivers/platform/x86/intel/int1092/Kconfig" > > source "drivers/platform/x86/intel/int33fe/Kconfig" > > source "drivers/platform/x86/intel/int3472/Kconfig" > > diff --git a/drivers/platform/x86/intel/Makefile b/drivers/platform/x86/intel/Makefile > > index 35f2066578b2..bd7f2ef5e767 100644 > > --- a/drivers/platform/x86/intel/Makefile > > +++ b/drivers/platform/x86/intel/Makefile > > @@ -5,6 +5,7 @@ > > # > > > > obj-$(CONFIG_INTEL_ATOMISP2_PDX86) += atomisp2/ > > +obj-$(CONFIG_INTEL_IFS) += ifs/ > > obj-$(CONFIG_INTEL_SAR_INT1092) += int1092/ > > obj-$(CONFIG_INTEL_CHT_INT33FE) += int33fe/ > > obj-$(CONFIG_INTEL_SKL_INT3472) += int3472/ > > diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig > > new file mode 100644 > > index 000000000000..88e3d4fa1759 > > --- /dev/null > > +++ b/drivers/platform/x86/intel/ifs/Kconfig > > @@ -0,0 +1,9 @@ > > +config INTEL_IFS > > + tristate "Intel In Field Scan" > > + depends on X86 && 64BIT && SMP > > Are there actual CONFIG_SMP and CONFIG_64BIT compilation dependencies > in this driver? It looks like this could compile without those config > dependencies. Don't think this is anything specific to compile dependencies. This is a server feature and only targetted and validated in those configs, untested and unsupported in 32bit configs.