X86 platform drivers
 help / color / mirror / Atom feed
From: Mark Pearson <mpearson-lenovo@squebb.ca>
To: mpearson-lenovo@squebb.ca
Cc: hdegoede@redhat.com, markgross@kernel.org,
	platform-driver-x86@vger.kernel.org,
	linux-kernel@vger.kernel.org, ilpo.jarvinen@linux.intel.com
Subject: [PATCH v4 5/8] platform/x86: think-lmi: Update password fields to use BIT
Date: Thu,  1 Jun 2023 16:05:49 -0400	[thread overview]
Message-ID: <20230601200552.4396-5-mpearson-lenovo@squebb.ca> (raw)
In-Reply-To: <20230601200552.4396-1-mpearson-lenovo@squebb.ca>

Code clean up to use BIT macro as suggested.

Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
Changes in v4:
 - New patch split out from previous patch #2.

 drivers/platform/x86/think-lmi.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/platform/x86/think-lmi.c b/drivers/platform/x86/think-lmi.c
index 564e3fc33cfb..e3be99b44ce0 100644
--- a/drivers/platform/x86/think-lmi.c
+++ b/drivers/platform/x86/think-lmi.c
@@ -169,11 +169,11 @@ MODULE_PARM_DESC(debug_support, "Enable debug command support");
  */
 #define LENOVO_CERT_THUMBPRINT_GUID "C59119ED-1C0D-4806-A8E9-59AA318176C4"
 
-#define TLMI_POP_PWD (1 << 0) /* Supervisor */
-#define TLMI_PAP_PWD (1 << 1) /* Power-on */
-#define TLMI_HDD_PWD (1 << 2) /* HDD/NVME */
-#define TLMI_SMP_PWD (1 << 6) /* System Management */
-#define TLMI_CERT    (1 << 7) /* Certificate Based */
+#define TLMI_POP_PWD BIT(0) /* Supervisor */
+#define TLMI_PAP_PWD BIT(1) /* Power-on */
+#define TLMI_HDD_PWD BIT(2) /* HDD/NVME */
+#define TLMI_SMP_PWD BIT(6) /* System Management */
+#define TLMI_CERT    BIT(7) /* Certificate Based */
 
 #define to_tlmi_pwd_setting(kobj)  container_of(kobj, struct tlmi_pwd_setting, kobj)
 #define to_tlmi_attr_setting(kobj)  container_of(kobj, struct tlmi_attr_setting, kobj)
-- 
2.40.1


  parent reply	other threads:[~2023-06-01 20:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-01 20:05 [PATCH v4 1/8] platform/x86: think-lmi: mutex protection around multiple WMI calls Mark Pearson
2023-06-01 20:05 ` [PATCH v4 2/8] platform/x86: think-lmi: Enable opcode support on BIOS settings Mark Pearson
2023-06-01 20:05 ` [PATCH v4 3/8] platform/x86: think-lmi: Correct System password interface Mark Pearson
2023-06-01 20:05 ` [PATCH v4 4/8] platform/x86: think-lmi: Update password attribute comments Mark Pearson
2023-06-01 20:05 ` Mark Pearson [this message]
2023-06-01 20:05 ` [PATCH v4 6/8] platform/x86: think-lmi: Correct NVME password handling Mark Pearson
2023-06-01 20:05 ` [PATCH v4 7/8] platform/x86: think-lmi: Correct NVME index default Mark Pearson
2023-06-01 20:05 ` [PATCH v4 8/8] platform/x86: think-lmi: Don't display unnecessary authentication settings Mark Pearson
2023-06-02 11:12   ` Ilpo Järvinen
2023-06-02 14:58     ` Mark Pearson
2023-06-06  9:33 ` [PATCH v4 1/8] platform/x86: think-lmi: mutex protection around multiple WMI calls Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230601200552.4396-5-mpearson-lenovo@squebb.ca \
    --to=mpearson-lenovo@squebb.ca \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=markgross@kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox