[PATCH platform-next 0/1] platform/x86: mlx-platform: Kconfig

[PATCH platform-next 0/1] platform/x86: mlx-platform: Kconfig

[Vadim Pasternak]

This fix is produced on top of:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=for-next

Fixes: 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
from for-next branch.

Vadim Pasternak (1):
  platform/x86: mlx-platform: Add dependency on PCI to Kconfig

 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.20.1

[PATCH platform-next 1/1] platform/x86: mlx-platform: Add dependency on PCI to Kconfig

[Vadim Pasternak]

Add dependency on PCI to avoid 'mlx-platform' compilation error in case
CONFIG_PCI is not set.

Failed on i386:
CONFIG_ACPI=y
CONFIG_ISA=y

Error In function 'mlxplat_pci_fpga_device_init':
implicit declaration of function 'pci_request_region':
 6204 |         err = pci_request_region(pci_dev, 0, res_name);
      |               ^~~~~~~~~~~~~~~~~~
      |               pci_request_regions

Fixes: 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
Reviewed-by: Michael Shych <michaelsh@nvidia.com>
---
 drivers/platform/x86/Kconfig | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
index a43db6731f34..2a1070543391 100644
--- a/drivers/platform/x86/Kconfig
+++ b/drivers/platform/x86/Kconfig
@@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
 
 config MLX_PLATFORM
 	tristate "Mellanox Technologies platform support"
-	depends on ACPI
-	depends on I2C
+	depends on ACPI && I2C && PCI
 	select REGMAP
 	help
 	  This option enables system support for the Mellanox Technologies
-- 
2.20.1

Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Add dependency on PCI to Kconfig

[Randy Dunlap]

On 8/29/23 06:37, Vadim Pasternak wrote:
> Add dependency on PCI to avoid 'mlx-platform' compilation error in case
> CONFIG_PCI is not set.
> 
> Failed on i386:
> CONFIG_ACPI=y
> CONFIG_ISA=y
> 
> Error In function 'mlxplat_pci_fpga_device_init':
> implicit declaration of function 'pci_request_region':
>  6204 |         err = pci_request_region(pci_dev, 0, res_name);
>       |               ^~~~~~~~~~~~~~~~~~
>       |               pci_request_regions
> 
> Fixes: 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
> Reviewed-by: Michael Shych <michaelsh@nvidia.com>


Reported-by: Randy Dunlap <rdunlap@infradead.org>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
>  drivers/platform/x86/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index a43db6731f34..2a1070543391 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
>  
>  config MLX_PLATFORM
>  	tristate "Mellanox Technologies platform support"
> -	depends on ACPI
> -	depends on I2C
> +	depends on ACPI && I2C && PCI
>  	select REGMAP
>  	help
>  	  This option enables system support for the Mellanox Technologies

-- 
~Randy

Re: [PATCH platform-next 1/1] platform/x86: mlx-platform: Add dependency on PCI to Kconfig

[Hans de Goede]

Hi,

On 8/29/23 15:37, Vadim Pasternak wrote:
> Add dependency on PCI to avoid 'mlx-platform' compilation error in case
> CONFIG_PCI is not set.
> 
> Failed on i386:
> CONFIG_ACPI=y
> CONFIG_ISA=y
> 
> Error In function 'mlxplat_pci_fpga_device_init':
> implicit declaration of function 'pci_request_region':
>  6204 |         err = pci_request_region(pci_dev, 0, res_name);
>       |               ^~~~~~~~~~~~~~~~~~
>       |               pci_request_regions
> 
> Fixes: 1316e0af2dc0 ("platform: mellanox: mlx-platform: Introduce ACPI init flow")
> Signed-off-by: Vadim Pasternak <vadimp@nvidia.com>
> Reviewed-by: Michael Shych <michaelsh@nvidia.com>

Thank you for your patch-series, I've applied the series to my
review-hans branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans



> ---
>  drivers/platform/x86/Kconfig | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/platform/x86/Kconfig b/drivers/platform/x86/Kconfig
> index a43db6731f34..2a1070543391 100644
> --- a/drivers/platform/x86/Kconfig
> +++ b/drivers/platform/x86/Kconfig
> @@ -965,8 +965,7 @@ config SERIAL_MULTI_INSTANTIATE
>  
>  config MLX_PLATFORM
>  	tristate "Mellanox Technologies platform support"
> -	depends on ACPI
> -	depends on I2C
> +	depends on ACPI && I2C && PCI
>  	select REGMAP
>  	help
>  	  This option enables system support for the Mellanox Technologies