X86 platform drivers
 help / color / mirror / Atom feed
From: Nikita Kravets <teackot@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: "Hans de Goede" <hdegoede@redhat.com>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Nikita Kravets" <teackot@gmail.com>,
	"Aakash Singh" <mail@singhaakash.dev>,
	"Jose Angel Pastrana" <japp0005@red.ujaen.es>
Subject: [PATCH v2 1/3] platform/x86: msi-ec: Fix the 3rd config
Date: Fri,  6 Oct 2023 20:53:53 +0300	[thread overview]
Message-ID: <20231006175352.1753017-5-teackot@gmail.com> (raw)
In-Reply-To: <20231006175352.1753017-3-teackot@gmail.com>

Fix the charge control address of CONF3 and remove an incorrect firmware
version which turned out to be a BIOS firmware and not an EC firmware.

Fixes: 392cacf2aa10 ("platform/x86: Add new msi-ec driver")
Cc: Aakash Singh <mail@singhaakash.dev>
Cc: Jose Angel Pastrana <japp0005@red.ujaen.es>
Signed-off-by: Nikita Kravets <teackot@gmail.com>
---
 drivers/platform/x86/msi-ec.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c
index f26a3121092f..492eb383ee7a 100644
--- a/drivers/platform/x86/msi-ec.c
+++ b/drivers/platform/x86/msi-ec.c
@@ -276,14 +276,13 @@ static struct msi_ec_conf CONF2 __initdata = {
 
 static const char * const ALLOWED_FW_3[] __initconst = {
 	"1592EMS1.111",
-	"E1592IMS.10C",
 	NULL
 };
 
 static struct msi_ec_conf CONF3 __initdata = {
 	.allowed_fw = ALLOWED_FW_3,
 	.charge_control = {
-		.address      = 0xef,
+		.address      = 0xd7,
 		.offset_start = 0x8a,
 		.offset_end   = 0x80,
 		.range_min    = 0x8a,
-- 
2.42.0


  reply	other threads:[~2023-10-06 17:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-06 17:53 [PATCH v2 0/3] platform/x86: msi-ec: add and fix EC configs Nikita Kravets
2023-10-06 17:53 ` Nikita Kravets [this message]
2023-10-09 11:27   ` [PATCH v2 1/3] platform/x86: msi-ec: Fix the 3rd config Ilpo Järvinen
2023-10-11  9:22   ` Hans de Goede
2023-10-06 17:53 ` [PATCH v2 2/3] platform/x86: msi-ec: rename fn_super_swap Nikita Kravets
2023-10-09 11:39   ` Ilpo Järvinen
2023-10-06 17:53 ` [PATCH v2 3/3] platform/x86: msi-ec: Add more EC configs Nikita Kravets
2023-10-09 11:40   ` Ilpo Järvinen
2023-10-09 11:57     ` Hans de Goede
2023-10-09 12:34       ` Ilpo Järvinen
2023-10-09 12:57         ` Hans de Goede
2023-10-09 13:10           ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231006175352.1753017-5-teackot@gmail.com \
    --to=teackot@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=japp0005@red.ujaen.es \
    --cc=mail@singhaakash.dev \
    --cc=platform-driver-x86@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox