From: Nikita Kravets <teackot@gmail.com>
To: platform-driver-x86@vger.kernel.org
Cc: Hans de Goede <hdegoede@redhat.com>,
Nikita Kravets <teackot@gmail.com>,
Aakash Singh <mail@singhaakash.dev>,
Jose Angel Pastrana <japp0005@red.ujaen.es>
Subject: [PATCH 5/5] platform/x86: msi-ec: Add a cooler boost attribute
Date: Tue, 10 Oct 2023 20:20:44 +0300 [thread overview]
Message-ID: <20231010172037.611063-13-teackot@gmail.com> (raw)
In-Reply-To: <20231010172037.611063-3-teackot@gmail.com>
Cooler boost increases the fan speed to improve the laptop cooling.
This is a simple on/off feature that is easy to test: if it works
you'll hear the fans spinning much faster. So far all supported models
have this feature represented by a single bit at the 0x98 EC address.
The attribute makes use of the previously added bit operation functions.
Cc: Aakash Singh <mail@singhaakash.dev>
Cc: Jose Angel Pastrana <japp0005@red.ujaen.es>
Signed-off-by: Nikita Kravets <teackot@gmail.com>
---
drivers/platform/x86/msi-ec.c | 35 +++++++++++++++++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/drivers/platform/x86/msi-ec.c b/drivers/platform/x86/msi-ec.c
index ae73dcf01d09..f4e770b3dda1 100644
--- a/drivers/platform/x86/msi-ec.c
+++ b/drivers/platform/x86/msi-ec.c
@@ -26,6 +26,7 @@
#include <linux/platform_device.h>
#include <linux/seq_file.h>
#include <linux/string.h>
+#include <linux/kstrtox.h>
#define SM_ECO_NAME "eco"
#define SM_COMFORT_NAME "comfort"
@@ -850,6 +851,35 @@ static struct acpi_battery_hook battery_hook = {
* Sysfs platform device attributes
*/
+static ssize_t cooler_boost_show(struct device *device,
+ struct device_attribute *attr, char *buf)
+{
+ int result;
+ bool value;
+
+ result = ec_check_bit(conf.cooler_boost.address, conf.cooler_boost.bit, &value);
+
+ return sysfs_emit(buf, "%s\n", value ? "on" : "off");
+}
+
+static ssize_t cooler_boost_store(struct device *dev,
+ struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ int result;
+ bool value;
+
+ result = kstrtobool(buf, &value);
+ if (result)
+ return result;
+
+ result = ec_set_bit(conf.cooler_boost.address, conf.cooler_boost.bit, value);
+ if (result < 0)
+ return result;
+
+ return count;
+}
+
static ssize_t fw_version_show(struct device *device,
struct device_attribute *attr, char *buf)
{
@@ -897,6 +927,7 @@ static ssize_t fw_release_date_show(struct device *device,
hour, minute, second);
}
+static DEVICE_ATTR_RW(cooler_boost);
static DEVICE_ATTR_RO(fw_version);
static DEVICE_ATTR_RO(fw_release_date);
@@ -922,6 +953,10 @@ static void filter_attributes(struct attribute_support *attributes,
static int msi_platform_probe(struct platform_device *pdev)
{
struct attribute_support root_attrs_support[] = {
+ {
+ &dev_attr_cooler_boost.attr,
+ conf.cooler_boost.address != MSI_EC_ADDR_UNSUPP,
+ },
{
&dev_attr_fw_version.attr,
true,
--
2.42.0
next prev parent reply other threads:[~2023-10-10 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-10 17:20 [PATCH 0/5] platform/x86: msi-ec: Add the first platform device attributes Nikita Kravets
2023-10-10 17:20 ` [PATCH 1/5] platform/x86: msi-ec: Register a platform driver Nikita Kravets
2023-10-11 13:00 ` Ilpo Järvinen
2023-10-12 12:30 ` Hans de Goede
2023-10-10 17:20 ` [PATCH 2/5] platform/x86: msi-ec: Add fw version and release date attributes Nikita Kravets
2023-10-11 12:41 ` Ilpo Järvinen
2023-10-12 12:34 ` Hans de Goede
2023-10-12 12:56 ` Ilpo Järvinen
2023-10-18 14:34 ` Hans de Goede
2025-02-20 12:25 ` N K
2023-10-10 17:20 ` [PATCH 3/5] platform/x86: msi-ec: Filter out unsupported attributes Nikita Kravets
2023-10-11 12:46 ` Ilpo Järvinen
2023-10-10 17:20 ` [PATCH 4/5] platform/x86: msi-ec: Add EC bit operation functions Nikita Kravets
2023-10-11 12:59 ` Ilpo Järvinen
2023-10-12 12:41 ` Hans de Goede
2023-10-10 17:20 ` Nikita Kravets [this message]
2023-10-11 12:49 ` [PATCH 5/5] platform/x86: msi-ec: Add a cooler boost attribute Ilpo Järvinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231010172037.611063-13-teackot@gmail.com \
--to=teackot@gmail.com \
--cc=hdegoede@redhat.com \
--cc=japp0005@red.ujaen.es \
--cc=mail@singhaakash.dev \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox